add bouncing ball example #6
Conversation
There was a problem hiding this comment.
Nice example and animation! The animation section is nicely commented. One minor concern
is that as presented in the example with radius=5, the "circle" appears as a "square". It would be nice to include more comments in the code about what the draw_circle function is actually doing to make it more clear why. I would suggest a larger value for the demo. radius=8 has some better shape to it.
|
After thinking about this some more and doing some searches to educate myself I think it would be sufficient just to reference something like https://en.wikipedia.org/wiki/Midpoint_circle_algorithm. At least for me, it was not immediately obvious what it was doing. This example serves 2 nice purposes - 1) animation and 2) circle drawing and it would be nice to demystify the circle drawing example a bit. |
Increased default radius, and added reference for circle drawing algorithm
|
Changes implemented via 74ff27a |
|
Looks great! Thanks! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.0.0 from 0.8.0: > use struct when available, list comp instead of map() (adafruit/Adafruit_CircuitPython_FXAS21002C#2) Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.0.0 from 0.8.0: > use struct when available, change map() to list comp (adafruit/Adafruit_CircuitPython_FXOS8700#4) Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#1 from tannewt/lint Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.1.0 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#21 from mrmcwethy/examples Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.0.0 from 2.0.1: > Fix up ReadTheDocs. (adafruit/Adafruit_CircuitPython_PCA9685#9) > Huge refactor, switch to PWMOut compatible API. (adafruit/Adafruit_CircuitPython_PCA9685#8) Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.1.0 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_SD#5 from mrmcwethy/examples Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.2.0 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#8 from dhalbert/master > add bouncing ball example (adafruit/Adafruit_CircuitPython_SSD1306#6) Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.0.1 from 1.0.0: > Changes to the tone function (adafruit/Adafruit_CircuitPython_SimpleIO#24) > Make lint happy > handle reversed range on output
hopefully this one doesn't throw as many linting issues