Skip to content

Provide reset pin support for I2C #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Conversation

dhalbert
Copy link
Contributor

@dhalbert dhalbert commented Jan 5, 2018

Fixes #7. Tested on an Adafruit 938 128x64 display, both with I2C and SPI. Also tested with a FeatherWing OLED with I2C.

@dhalbert dhalbert requested a review from a team January 5, 2018 17:58
@ladyada
Copy link
Member

ladyada commented Jan 5, 2018

looks good to me, do you want to fix up the pylint before merging?

@ladyada ladyada merged commit 3e62708 into adafruit:master Jan 5, 2018
@dhalbert
Copy link
Contributor Author

dhalbert commented Jan 5, 2018

Tnx! I'll update the Learn Guide as well.

@ladyada
Copy link
Member

ladyada commented Jan 5, 2018

oops i started doing that too! ill wrap it up and you can check it

@dhalbert
Copy link
Contributor Author

dhalbert commented Jan 5, 2018

The SPI example is wrong: uses RPi pin designations, and the args need to be DigitalInOuts rather than just pin names.

@ladyada
Copy link
Member

ladyada commented Jan 5, 2018

ok i did I2C example and will fix SPI now
https://learn.adafruit.com/micropython-hardware-ssd1306-oled-display/circuitpython
check it?

@dhalbert
Copy link
Contributor Author

dhalbert commented Jan 5, 2018

Guide fixes look excellent! Thanks!

tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 10, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.0.0 from 0.8.0:
  > use struct when available, list comp instead of map() (adafruit/Adafruit_CircuitPython_FXAS21002C#2)

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.0.0 from 0.8.0:
  > use struct when available, change map() to list comp (adafruit/Adafruit_CircuitPython_FXOS8700#4)

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.0.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#1 from tannewt/lint

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.1.0 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#21 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.0.0 from 2.0.1:
  > Fix up ReadTheDocs. (adafruit/Adafruit_CircuitPython_PCA9685#9)
  > Huge refactor, switch to PWMOut compatible API. (adafruit/Adafruit_CircuitPython_PCA9685#8)

Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.1.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SD#5 from mrmcwethy/examples

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.2.0 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#8 from dhalbert/master
  > add bouncing ball example (adafruit/Adafruit_CircuitPython_SSD1306#6)

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.0.1 from 1.0.0:
  > Changes to the tone function (adafruit/Adafruit_CircuitPython_SimpleIO#24)
  > Make lint happy
  > handle reversed range on output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants