Fix up ReadTheDocs. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 10, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 1.0.0 from 0.8.0: > use struct when available, list comp instead of map() (adafruit/Adafruit_CircuitPython_FXAS21002C#2) Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 1.0.0 from 0.8.0: > use struct when available, change map() to list comp (adafruit/Adafruit_CircuitPython_FXOS8700#4) Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#1 from tannewt/lint Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 3.1.0 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#21 from mrmcwethy/examples Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.0.0 from 2.0.1: > Fix up ReadTheDocs. (adafruit/Adafruit_CircuitPython_PCA9685#9) > Huge refactor, switch to PWMOut compatible API. (adafruit/Adafruit_CircuitPython_PCA9685#8) Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.1.0 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_SD#5 from mrmcwethy/examples Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.2.0 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#8 from dhalbert/master > add bouncing ball example (adafruit/Adafruit_CircuitPython_SSD1306#6) Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.0.1 from 1.0.0: > Changes to the tone function (adafruit/Adafruit_CircuitPython_SimpleIO#24) > Make lint happy > handle reversed range on output
deshipu
reviewed
Jan 10, 2018
| @@ -122,7 +122,9 @@ class PCA9685: | |||
| def __init__(self, i2c_bus, *, address=0x40, reference_clock_speed=25000000): | |||
| self.i2c_device = i2c_device.I2CDevice(i2c_bus, address) | |||
| self.channels = PCAChannels(self) | |||
| """Sequence of 16 `PWMChannel` objects. One for each channel.""" | |||
There was a problem hiding this comment.
I think you mean to use comments here, not strings?
There was a problem hiding this comment.
Nope, this is how sphinx (and I think Python) do attribute doc strings. They appear in RTD as expected: https://circuitpython.readthedocs.io/projects/pca9685/en/latest/api.html#adafruit_pca9685.PCA9685.channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.