Get rid of "Get or set" methods

[tannewt]

Get or set methods are a weird programming pattern inherited from MicroPython. It should be replaced with properties instead.

[caternuson]

What's a good approach for using properties with 2D matrix like things? I think various syntaxes could be accommodated.

pixels[x][y] = color

or

pixels[x,y] = color

[deshipu]

Both have their problems. In the first case, you have to create an intermediate object with its own getters and setters. In the second case, you have to create the tuple. That makes them slow and gives one more opportunity for memory fragmentation.

[deshipu]

Also, it should be pixels[y][x], as it's arranged by rows first and columns second.

[tannewt]

The Python pillow library does [x,y]: https://pillow.readthedocs.io/en/5.1.x/reference/PixelAccess.html

[caternuson]

Works for me. Makes sense to follow suit with pillow. Any objections to going ahead and using this syntax for 2D property access?

[deshipu]

I wonder if you would also want to have slices there for doing filled rectangles?

[deshipu]

By the way, I would really recommend leaving the pixel method there, and only get rid of the blinking and brightness setters. There are many libraries that will work with anything that has a pixel method. Then again, you can probably just pass a framebuf object to them directly.

[caternuson]

#11 did some of this for the HT16K33 class and the matrix like displays. But still need to do something for the segmented displays.

Could do something like this, which would just be a simple refactoring of the current code:

disp.text = "hello"
disp.number = 42

or maybe try and add something that acts more like print():

disp.print("hello")
disp.print(42)

[deshipu]

I like the latter option much more.

[tannewt]

+1 print

…

On Mon, Jun 18, 2018 at 8:58 AM Radomir Dopieralski < ***@***.***> wrote: I like the latter option much more. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADNqTg16k70Rud4-La3bks6SZrW8BdKks5t984cgaJpZM4Q6Gp-> .

[caternuson]

I think with #12 , this should be done. OK to close?

[tannewt]

Yup! Up to you.

…

On Thu, Jun 21, 2018 at 4:03 PM Carter Nelson ***@***.***> wrote: I think with #12 <#12> , this should be done. OK to close? # — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADNqeII0QhPZSlxejE28ImbUeMVSZ3nks5t_CYlgaJpZM4Q6Gp-> .