Fix issue #4429: added java code for Spiral Matrix II #4438

zaidiyazdan · 2023-09-29T17:49:44Z

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

zaidiyazdan · 2023-09-29T18:42:57Z

Can some one please help me with Clang format ?

vil02 · 2023-09-29T19:44:04Z

Can some one please help me with Clang format ?

You can format your code with the command (run it somewhere inside this project directory):

clang-format -i --style=file path/to/your/file.java

If you do not have the correct version of clang-format (i.e. < 16.0), you can remove this line:

Java/.clang-format

Line 86 in ea0eef1

InsertNewlineAtEOF: true

and add the new line symbol at the end of your file manually (but do not commit the changed .clang-format file).

If you use gitpod, everything should run smoothly there.

vil02 · 2023-09-29T19:45:39Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

+    public static void main(String[] args) {
+        SpiralMatrixII solution = new SpiralMatrixII();
+        int n = 3;
+        int[][] result = solution.generateMatrix(n);
+
+        for (int i = 0; i < n; i++) {
+            System.out.println(Arrays.toString(result[i]));
+        }


Please remove the main method and add some proper tests. Good examples to look at:

Factorial and FactorialTest,

FindMax and FindMaxTest.

okay i will change it

vil02 · 2023-09-29T19:47:18Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

+import java.util.Arrays;
+
+public class SpiralMatrixII {
+    public int[][] generateMatrix(int n) {


Suggested change

public int[][] generateMatrix(int n) {

static public int[][] generateMatrix(int n) {

I would l suggest to rename the variable n to something like size.

What happens if n is negative?

okay i will look after it

vil02 · 2023-09-29T19:48:10Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

+
+import java.util.Arrays;
+
+public class SpiralMatrixII {


Why not to make a proper utility class out of this?

Suggested change

public class SpiralMatrixII {

public final class SpiralMatrixII {

private SpiralMatrixII() {

}

vil02 · 2023-09-29T19:48:36Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

@@ -0,0 +1,49 @@
+package com.thealgorithms.others;
+
+import java.util.Arrays;


This import is not used. Is that right?

Suggested change

import java.util.Arrays;

ohh yup ... Sorry i would have missed it

zaidiyazdan · 2023-09-29T20:54:34Z

@vil02 done with all the changes please check it out

vil02 · 2023-09-30T15:49:11Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

+    public static void main(String[] args) {
+        SpiralMatrixII solution = new SpiralMatrixII();
+        int size = 3;
+        int[][] result = solution.generateMatrix(size);
+        for (int i = 0; i < size; i++) {
+            System.out.println(Arrays.toString(result[i]));
+        }
+    }


Suggested change

public static void main(String[] args) {

SpiralMatrixII solution = new SpiralMatrixII();

int size = 3;

int[][] result = solution.generateMatrix(size);

for (int i = 0; i < size; i++) {

System.out.println(Arrays.toString(result[i]));

}

}

vil02 · 2023-09-30T15:49:48Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

+public final class SpiralMatrixII {
+    private SpiralMatrixII() {
+    }
+    static public int[][] generateMatrix(int size) {


Suggested change

static public int[][] generateMatrix(int size) {

public static int[][] generateMatrix(final int size) {

vil02 · 2023-09-30T15:50:49Z

src/main/java/com/thealgorithms/others/SpiralMatrixII.java

+        while (num <= size * size) {
+            // Traverse right
+            for (int i = left; i <= right && num <= size * size; i++) {
+                result[top][i] = num++;
+            }
+            top++;
+
+            // Traverse down
+            for (int i = top; i <= bottom && num <= size * size; i++) {
+                result[i][right] = num++;
+            }
+            right--;
+
+            // Traverse left
+            for (int i = right; i >= left && num <= size * size; i--) {
+                result[bottom][i] = num++;
+            }
+            bottom--;
+
+            // Traverse up
+            for (int i = bottom; i >= top && num <= size * size; i--) {
+                result[i][left] = num++;
+            }
+            left++;
+        }


This should be simplified.

vil02 · 2023-09-30T15:52:20Z

src/test/java/com/thealgorithms/others/SpiralMatrixIITest.java

+    @Test
+    public void testGeneratedMatrixSize() {
+        int size = 3; // Change this to test different matrix sizes
+        int[][] result = SpiralMatrixII.generateMatrix(size);
+        assertEquals(size, result.length);
+        for (int i = 0; i < size; i++) {
+            assertEquals(size, result[i].length);
+        }
+    }


This test does not add any value: if testGeneratedMatrixCorrectness passes, this will also pass.

Suggested change

@Test

public void testGeneratedMatrixSize() {

int size = 3; // Change this to test different matrix sizes

int[][] result = SpiralMatrixII.generateMatrix(size);

assertEquals(size, result.length);

for (int i = 0; i < size; i++) {

assertEquals(size, result[i].length);

}

}

vil02 · 2023-10-21T15:10:15Z

@zaidiyazdan are you still working on this? if not, please close this PR.

Fix issue #4429: added java code for Spiral Matrix II

a3aca77

zaidiyazdan requested review from yanglbme, debasishbsws, vil02 and BamaCharanChhandogi as code owners September 29, 2023 17:49

zaidiyazdan added 2 commits September 29, 2023 23:26

changes made according to format linter

1c8d34d

Changed format

8783b2b

style: use proper formatting

8c96ae1

vil02 requested changes Sep 29, 2023

View reviewed changes

vil02 self-assigned this Sep 29, 2023

zaidiyazdan added 4 commits September 30, 2023 01:59

Implemented suggested changes

c3a183e

final changes

bda1216

formatting done with changes

c7dc9c0

importing Arrays is essentical added it

f874a14

vil02 requested changes Sep 30, 2023

View reviewed changes

Prabhat-Kumar-42 mentioned this pull request Oct 1, 2023

Add AhoCorasick #4465

Merged

5 tasks

This was referenced Oct 1, 2023

rewrote as parameterized tests #4458

Merged

Add itinerary tickets code #4340

Closed

zaidiyazdan closed this Oct 25, 2023

vil02 mentioned this pull request Jan 6, 2024

Added KURATSUBA ALGORITHM FOR CALCULATING MULTIPLICATION in java #4996

Closed

6 tasks

vil02 mentioned this pull request Jan 21, 2024

Add tests SumOfSubset #5021

Merged

vil02 mentioned this pull request Jan 31, 2024

Add WelshPowell (Graph Colouring) #5034

Merged

6 tasks

	public int[][] generateMatrix(int n) {
	static public int[][] generateMatrix(int n) {

		@@ -0,0 +1,49 @@
		package com.thealgorithms.others;

		import java.util.Arrays;

	static public int[][] generateMatrix(int size) {
	public static int[][] generateMatrix(final int size) {

Fix issue #4429: added java code for Spiral Matrix II #4438

Fix issue #4429: added java code for Spiral Matrix II #4438

Uh oh!

Conversation

zaidiyazdan commented Sep 29, 2023

Uh oh!

zaidiyazdan commented Sep 29, 2023

Uh oh!

vil02 commented Sep 29, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zaidiyazdan commented Sep 29, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vil02 commented Oct 21, 2023

Uh oh!

Uh oh!