Skip to content

Add itinerary tickets code #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Imbiber
Copy link

@Imbiber Imbiber commented Aug 30, 2023

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Please fix PR check https://github.com/TheAlgorithms/Java/actions/runs/6054455394/job/16431883329?pr=4340
There is some excessive whitespace

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general code looks good - no need for some big changes. Here are my small suggestions (some of them will fix the CI errors). You probably know its - It is enough to click Commit suggestion button.

@Imbiber
Copy link
Author

Imbiber commented Oct 4, 2023

In general code looks good - no need for some big changes. Here are my small suggestions (some of them will fix the CI errors). You probably know its - It is enough to click Commit suggestion button.

@vil02 can you help me out. I tried, but failed to correct the error last time , you providing me changes has given me hope.
It still failed Clang format linter / build (pull_request) . How to solve it?

@vil02
Copy link
Member

vil02 commented Oct 7, 2023

@Imbiber regarding clang-format, please have a look at: #4438 (comment)

It seems that you need to change the order of the imports (cf. log) - this can be done by hand.

Comment on lines +21 to +27
for (String key : tickets.keySet()) {
revTickets.put(tickets.get(key), key);
}
for (String key : tickets.keySet()) {
if (!revTickets.containsKey(key)) {
return key; // Starting point
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about such renaming?

Suggested change
for (String key : tickets.keySet()) {
revTickets.put(tickets.get(key), key);
}
for (String key : tickets.keySet()) {
if (!revTickets.containsKey(key)) {
return key; // Starting point
}
for (final var startStation : tickets.keySet()) {
revTickets.put(tickets.get(startStation), startStation);
}
for (final var startStation : tickets.keySet()) {
if (!revTickets.containsKey(startStation)) {
return startStation; // Starting point
}

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Feb 23, 2024
Copy link

github-actions bot commented Mar 1, 2024

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants