Skip to content

rewrote as parameterized tests #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 1, 2023

Conversation

asapekia
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case, which covers the situation in which the condition in the line:


Is satisfied?

And please fix the formatting.

@vil02 vil02 self-assigned this Sep 30, 2023
@asapekia
Copy link
Contributor Author

asapekia commented Oct 1, 2023

can someone help me with the formatting. I am unable to use clang formatter on my laptop.

@vil02
Copy link
Member

vil02 commented Oct 1, 2023

can someone help me with the formatting. I am unable to use clang formatter on my laptop.

Please have a look here.

I pushed 2276b72 - it should fix the formatting.

@asapekia
Copy link
Contributor Author

asapekia commented Oct 1, 2023

Could you please add a test case, which covers the situation in which the condition in the line:

Is satisfied?
And please fix the formatting.

yes I have added the test cases that will produce negative hash(t).

@asapekia
Copy link
Contributor Author

asapekia commented Oct 1, 2023

can someone help me with the formatting. I am unable to use clang formatter on my laptop.

Please have a look here.

I pushed 2276b72 - it should fix the formatting.

Thanks @vil02. This PR can be merged now.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asapekia would you like to clean-up RabinKarpAlgorithm?

@vil02 vil02 merged commit f72b80b into TheAlgorithms:master Oct 1, 2023
@asapekia
Copy link
Contributor Author

asapekia commented Oct 1, 2023

@asapekia would you like to clean-up RabinKarpAlgorithm?

yes. Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants