-
Notifications
You must be signed in to change notification settings - Fork 20k
rewrote as parameterized tests #4458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
asapekia
commented
Sep 30, 2023
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test case, which covers the situation in which the condition in the line:
if (t < 0) t = (t + q); |
Is satisfied?
And please fix the formatting.
src/test/java/com/thealgorithms/searches/RabinKarpAlgorithmTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/thealgorithms/searches/RabinKarpAlgorithmTest.java
Outdated
Show resolved
Hide resolved
can someone help me with the formatting. I am unable to use clang formatter on my laptop. |
yes I have added the test cases that will produce negative hash(t). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asapekia would you like to clean-up RabinKarpAlgorithm
?
yes. Working on it. |