Add `AhoCorasick` #4465

Prabhat-Kumar-42 · 2023-09-30T22:15:33Z

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Prabhat-Kumar-42 · 2023-09-30T23:48:51Z

Hey,
I added code for the Aho-Corasick algorithm.
This code should work for all the test cases.
Please review it, if any issue arises, please let me know.
I hope It will help the community.
Thank You !! :)

Manish-Rawat-1186 · 2023-10-01T04:53:45Z

bro how did you convert into clang format

Prabhat-Kumar-42 · 2023-10-01T05:29:47Z

bro how did you convert into clang format

Hey, below are the steps for clang.
You can format your code with the command (run it somewhere inside this project directory):

clang-format -i --style=file path/to/your/file.java

If you do not have the correct version of clang-format (i.e. < 16.0), you can remove this line:

Java/.clang-format

Line 86 in ea0eef1

InsertNewlineAtEOF: true

and add the new line symbol at the end of your file manually (but do not commit the changed .clang-format file).

If you use gitpod, everything should run smoothly there.

Originally posted by @vil02 in #4438 (comment)

Prabhat-Kumar-42 · 2023-10-01T09:15:08Z

I request the maintainer(s) to please merge my request using "hacktoberfest-accepted" label.
Also, I would like to be assigned to this for any future issues or anything related.
Thank You !!

…his branch

src/main/java/com/thealgorithms/strings/AhoCorasick.java

… functions.

…into AhoCorasick updating the branch with upstream

vil02

Interesting contribution!

The code is quite complex - it could be simplified by introducing some new helper methods. It is not easy, but we will make it perfect!

src/main/java/com/thealgorithms/strings/AhoCorasick.java

src/test/java/com/thealgorithms/strings/AhoCorasickTest.java

…ldNodesOfTheRoot() method, hashmap string search position (also has previous index based search), removed java.util.*

…into AhoCorasick updated local repo with that of github

…into AhoCorasick

Prabhat-Kumar-42 · 2023-10-08T04:14:30Z

Hey @vil02 ,

I have updated the changes you have mentioned.

Please review the code.

If there's anything that needs to be modified, please let me know.

Thank You !!

src/main/java/com/thealgorithms/strings/AhoCorasick.java

src/test/java/com/thealgorithms/strings/AhoCorasickTest.java

src/main/java/com/thealgorithms/strings/AhoCorasick.java

…thod initializePositionByStringIndexValue()

…on recording in searchIn()

Prabhat-Kumar-42 · 2023-10-08T12:42:17Z

Hey @vil02 ,

I have updated the changes you have mentioned.

I tried what you said above about wrapping up pattern indexing in another class. I hope you like it.

Still If there's any thing that needs to be added or if you want me to revert it back to how it was, please do tell me. I will address it asap.

Please review the code.

Thank You !!

…into AhoCorasick

src/main/java/com/thealgorithms/strings/AhoCorasick.java

vil02 · 2023-10-08T13:13:18Z

@Prabhat-Kumar-42 wow, this was a pull-request. Thanks!

vil02 · 2023-10-08T13:17:12Z

Closes #4464.

Prabhat-Kumar-42 · 2023-10-08T13:20:19Z

Thanks @vil02 , It was fun working with you and I learned a lot in the process.
I am looking forward to contributing more and working with you.
Thank you again !!

Prabhat-Kumar-42 added 5 commits September 30, 2023 17:17

Added code to find Articulation Points and Bridges

8bacb96

tried to solve clang-formant test

478bf04

removed new line at EOF to get lint to pass

8e88928

feature: Added Ahocorasick Algorithm

db5d447

fixed lint using clang-format

2cc9e3f

Prabhat-Kumar-42 requested review from yanglbme, debasishbsws, vil02 and BamaCharanChhandogi as code owners September 30, 2023 22:15

removed datastructures/graphs/ArticulationPointsAndBridge.java from t…

d2acaf6

…his branch

vil02 requested changes Oct 1, 2023

View reviewed changes

src/main/java/com/thealgorithms/strings/AhoCorasick.java Outdated Show resolved Hide resolved

Prabhat-Kumar-42 added 6 commits October 2, 2023 00:36

removed main, since test-file is added. Also modified and renamed few…

37c92ad

… functions.

Added test-file for AhoCorasick Algorithm

efd912d

Modified some comments in test-file

194a37d

Modified some comments in AhoCorasick.java

288168c

lint fix

6c4e2c2

Merge branch 'master' into AhoCorasick

ab22511

Prabhat-Kumar-42 requested a review from vil02 October 1, 2023 19:39

Prabhat-Kumar-42 added 4 commits October 2, 2023 01:18

added few more test cases

af71647

Merge branch 'AhoCorasick' of https://github.com/Prabhat-Kumar-42/Java …

96f6231

…into AhoCorasick updating the branch with upstream

Modified some comments

59dfa0e

Merge branch 'master' into AhoCorasick

b135163

vil02 requested changes Oct 2, 2023

View reviewed changes

Prabhat-Kumar-42 added 3 commits October 2, 2023 18:17

Change all class fields to private, added initializeSuffixLinksForChi…

6a75149

…ldNodesOfTheRoot() method, hashmap string search position (also has previous index based search), removed java.util.*

Added Missing Test-Cases and more

dd50c78

Merge branch 'AhoCorasick' of https://github.com/Prabhat-Kumar-42/Java …

f464bf8

…into AhoCorasick updated local repo with that of github

Prabhat-Kumar-42 added 3 commits October 8, 2023 09:16

lint fix clang

846bbda

Merge branch 'AhoCorasick' of https://github.com/Prabhat-Kumar-42/Java …

82586b4

…into AhoCorasick

minor chage - 'removed a comment'

6f81843

Prabhat-Kumar-42 marked this pull request as ready for review October 8, 2023 04:13

Prabhat-Kumar-42 requested a review from vil02 October 8, 2023 04:16

vil02 requested changes Oct 8, 2023

View reviewed changes

Prabhat-Kumar-42 marked this pull request as draft October 8, 2023 10:24

vil02 mentioned this pull request Oct 8, 2023

Searching algo ahocorasick string search algorithm #4724

Closed

5 tasks

Prabhat-Kumar-42 added 4 commits October 8, 2023 17:33

added final fields to some arguments, class and variables, added a me…

4fa8df1

…thod initializePositionByStringIndexValue()

updated to remove * inclusion and added the required modules only

4a53103

Implemented a new class PatternPositionRecorder to wrap up the positi…

653db0b

…on recording in searchIn()

Merge branch 'master' into AhoCorasick

a2ec697

Prabhat-Kumar-42 marked this pull request as ready for review October 8, 2023 12:42

Prabhat-Kumar-42 requested a review from vil02 October 8, 2023 12:42

Prabhat-Kumar-42 added 2 commits October 8, 2023 18:18

Added final fields to PatternPositionRecorder Class

b409f7a

Merge branch 'AhoCorasick' of https://github.com/Prabhat-Kumar-42/Java …

eb1c369

…into AhoCorasick

vil02 requested changes Oct 8, 2023

View reviewed changes

src/main/java/com/thealgorithms/strings/AhoCorasick.java Show resolved Hide resolved

src/main/java/com/thealgorithms/strings/AhoCorasick.java Outdated Show resolved Hide resolved

vil02 added 2 commits October 8, 2023 15:06

style: mark default constructor of AhoCorasick as private

b38f067

style: remoce redundant public

c7c743b

vil02 approved these changes Oct 8, 2023

View reviewed changes

vil02 changed the title ~~#4464 - Implemented Aho-Corasick Algorithm~~ Add AhoCorasick Oct 8, 2023

vil02 merged commit 8200a79 into TheAlgorithms:master Oct 8, 2023

vil02 mentioned this pull request Oct 8, 2023

[FEATURE REQUEST] Aho–Corasick algorithm #4464

Closed

vil02 mentioned this pull request Oct 8, 2023

#4459 - Added code to find Articulation Points and Bridges #4453

Closed

5 tasks

vil02 mentioned this pull request Oct 22, 2023

[FEATURE REQUEST] Vernam Cipher #4478

Closed

Add AhoCorasick #4465

Add AhoCorasick #4465

Uh oh!

Conversation

Prabhat-Kumar-42 commented Sep 30, 2023

Uh oh!

Prabhat-Kumar-42 commented Sep 30, 2023

Uh oh!

Manish-Rawat-1186 commented Oct 1, 2023

Uh oh!

Prabhat-Kumar-42 commented Oct 1, 2023

Uh oh!

Prabhat-Kumar-42 commented Oct 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vil02 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Prabhat-Kumar-42 commented Oct 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Prabhat-Kumar-42 commented Oct 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vil02 commented Oct 8, 2023

Uh oh!

vil02 commented Oct 8, 2023

Uh oh!

Prabhat-Kumar-42 commented Oct 8, 2023

Uh oh!

Uh oh!

Add `AhoCorasick` #4465

Add `AhoCorasick` #4465

Prabhat-Kumar-42 commented Oct 1, 2023 •

edited

Loading

Prabhat-Kumar-42 commented Oct 8, 2023 •

edited

Loading