Skip to content

[FEATURE REQUEST] Vernam Cipher #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amansheoran15 opened this issue Oct 1, 2023 · 11 comments
Closed

[FEATURE REQUEST] Vernam Cipher #4478

amansheoran15 opened this issue Oct 1, 2023 · 11 comments
Assignees

Comments

@amansheoran15
Copy link

What would you like to Propose?

I'd like to implement vernam cipher for cipher folder.

Issue details

Currently vernam cipher is missing in ciphers folder, I'd like to implement it.

Additional Information

No response

@krupalitandel1
Copy link

Hey there I would like to contribute to this project, please assign me this issue

@Rohxn16
Copy link

Rohxn16 commented Oct 8, 2023

I want to work on this issue

@vil02 vil02 changed the title [FEATURE REQUEST] <title> Vernam Cipher [FEATURE REQUEST] Vernam Cipher Oct 22, 2023
@vil02
Copy link
Member

vil02 commented Oct 22, 2023

@amansheoran15 are you working on this? I could not find your PR. If not, please inform us. It seems that @krupalitandel1 and @Rohxn16 want do do it.

@amansheoran15
Copy link
Author

I was waiting for approval to do this , I'll do this

@vil02
Copy link
Member

vil02 commented Oct 22, 2023

I was waiting for approval to do this , I'll do this

@amansheoran15 great! When you will be ready, please mention me in the PR. Please make sure to add tests of your implementation (and do not add the main method to your class). Some good PR to look at:

@amansheoran15
Copy link
Author

I'm not able to run the code , it says to upgrade version to 17 , I use Java SDK 16.
Also how to test code without main ? I'm confused

@vil02
Copy link
Member

vil02 commented Oct 22, 2023

I guess you will add tests for your class like VernamCipherTest.java. You can type in the console (in the root of this project) something like

mvn test

or

mvn test -Dtest=VernamCipherTest

just to test your implementation.

If you have problems with creating a local environment, you can always use gitpod - this repo is setup to work there.

@Rohxn16
Copy link

Rohxn16 commented Oct 22, 2023

I wanna work on this is one, is it available now?

@vil02
Copy link
Member

vil02 commented Oct 22, 2023

I wanna work on this is one, is it available now?

I think @amansheoran15 is working on it.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

@github-actions github-actions bot added the stale label Feb 15, 2024
Copy link

Please reopen this issue once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants