feat: support only webpack workflow #4550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pareJS method with own logic
chore: remove the code related to js prepare as webpack overrides prepareJS method with own logic
chore: remove projectTemplate logic
…y-code chore: remove the legacy code from android-project-service
chore: delete plugin variables service
chore: remove legacy code from ios-project-service
* remove the support for targetSdk * extract the logic to separate services
refactor: refactor the logic for building android projects
chore: automate publish of webpack tag
ghost
assigned 
|
test cli-smoke nativescript@webpack |
|
test cli-smoke |
fix: fix the unit tests execution with istanbul
# Conflicts: # lib/services/android-project-service.ts # test/plugins-service.ts
|
test cli-smoke cli-create cli-plugin cli-preview cli-tests cli-templates cli-run cli-build cli-device cli-misc nativescript@webpack nativescript-dev-webpack@webpack |
|
test cli-smoke nativescript#webpack branch_cli_tests#webpack_back |
|
test nativescript#webpack branch_cli_create#webpack |
|
test nativescript#webpack branch-cli#webpack_back |
|
test nativescript#webpack branch_cli_create#webpack_back |
|
test nativescript#webpack branch-cli#webpack_back |
…n already added To reproduce: 1. `tns platform add [email protected]` 2. `tns platform clean ios` Expected output: Platform ios successfully removed. Copying template files... Platform ios successfully added. v5.1.0 Actual output: Platform ios successfully removed. Copying template files... Platform ios successfully added. v5.4.2
NativeScript CLI returns that there are no added platforms when iOS platform is already added as the comparison is case sensitive.
The `kinvey-sdk` plugin relies on `preview-sync` hook and mainly on platform property from `hookArgs`. This PR changes the workflow of `preview-sync` hook and makes it the same as in NativeScript v5.4.0. In NativeScript v5.4.0 the hook is executed when pubnub reports the device that the QR code is scanned with. This way we're able to get the platform from device and adds it to the `hookArgs` passed to the hook.
fix: fix the workflow of preview-sync hook
fix: fix `tns platform list` and `tns platform clean` commands
|
test cli-smoke nativescript#webpack branch_cli_create#webpack_back |
Currently, in case the Android's App_Resources structure is migrated, we copy the files twice. Fix this by setting correct folders to copy the files.
…urces fix: fix the way android appResources are processed
fix: show warning when --env.snapshot is provided for debug builds
Enable passing iOS Code signing options to operations like run/debug, etc. Currently the provision and teamId options are not passed to the controllers, so we do not use them during project preparation. To resolve this, include the buildData in the deviceDescriptors - this way we'll have all the codesigning data required for the specific device and we'll also allow having different codesign options for different devices. Also remove outputPath from deviceDescriptors as we can use it directly from the buildData.
fix: initialize nativeChanged with true when checking for changes
…e and simulator NativeScript CLI doesn't respect correctly the built application package when there are connected device and simulator. That is the reason why `tns deploy ios --path TestApp --provision NativeScriptDevProfile –justlaunch` throws the following error: ENOENT: no such file or directory, scandir '/Users/mivanova/Projects/TestApp/platforms/ios/build/Debug-iphonesimulator'
As buildData has nativePrepare property, when using the runController. Set the nativePrepare last in the merged object.
fix: fix `tns deploy ios --justlaunch` when there are connected device and simulator
fix: enable passing iOS codesigning options to LiveSync operations
DimitarTachev
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].