fix: fix tns platform list and tns platform clean commands
#4733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n already added To reproduce: 1. `tns platform add [email protected]` 2. `tns platform clean ios` Expected output: Platform ios successfully removed. Copying template files... Platform ios successfully added. v5.1.0 Actual output: Platform ios successfully removed. Copying template files... Platform ios successfully added. v5.4.2
NativeScript CLI returns that there are no added platforms when iOS platform is already added as the comparison is case sensitive.
Fatme
changed the title
tns platform list and tns platform clean commands
rosen-vladimirov
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
clean command
tns cleancommand doesn't add the correct platform.To reproduce:
tns platform add [email protected]tns cleanExpected: The steps above should delete
[email protected]and install again[email protected]Actual: The platform
[email protected]is deleted but[email protected]is added instead.platform list
tns platform listcommand doesn't work when there is already added platform. This is due to the fact that NativeScript CLI makes case sensitive comparison when getting already installed platforms.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].