Skip to content

fix: fix the way android appResources are processed #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 15, 2019

Currently we copy all App_Resources from ./app/App_Resources/Android/* to ./platforms/../app/src. As there is src folder in ./app/App_Resources/Android/*, we receive as a result inside platforms ./platforms/app/../src/src.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Currently we copy all App_Resources from ./app/App_Resources/Android/* to ./platforms/../app/src. As there is src folder in ./app/App_Resources/Android/*, we receive as a result inside platforms ./platforms/app/../src/src.
@cla-bot cla-bot bot added the cla: yes label Jun 15, 2019
Currently, in case the Android's App_Resources structure is migrated, we copy the files twice. Fix this by setting correct folders to copy the files.
@Fatme Fatme merged commit 76dc9c4 into feature/webpack-only Jun 18, 2019
@Fatme Fatme deleted the fatme/fix-android-app-resources branch June 18, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants