chore: remove the code related to js prepare as webpack overrides prepareJS method with own logic #4516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pareJS method with own logic
ghost
assigned 
KristianDD
reviewed
Apr 10, 2019
| const appFolderExists = this.$fs.exists(path.join(platformData.appDestinationDirectoryPath, constants.APP_FOLDER_NAME)); | ||
| if (appFolderExists) { | ||
| this.preparePluginScripts(pluginData, platform, projectData, projectFilesConfig); | ||
| await this.preparePluginNativeCode(pluginData, platform, projectData); |
There was a problem hiding this comment.
This should be moved somewhere maybe.
KristianDD
reviewed
Apr 10, 2019
| @@ -36,23 +34,7 @@ export class PreparePlatformJSService extends PreparePlatformService implements | |||
| @performanceLog() | |||
| @hook('prepareJSApp') | |||
| public async preparePlatform(config: IPreparePlatformJSInfo): Promise<void> { | |||
| if (!config.changesInfo || config.changesInfo.appFilesChanged || config.changesInfo.changesRequirePrepare) { | |||
| await this.copyAppFiles(config); | |||
| this.copyAppResourcesFiles(config); | |||
There was a problem hiding this comment.
We might need to move this call somewhere else.
KristianDD
reviewed
Apr 10, 2019
| const appDestinationDirectoryPath = path.join(config.platformData.appDestinationDirectoryPath, constants.APP_FOLDER_NAME); | ||
| const appResourcesDirectoryPath = path.join(appDestinationDirectoryPath, path.basename(config.projectData.appResourcesDirectoryPath)); | ||
| if (this.$fs.exists(appResourcesDirectoryPath)) { | ||
| this.$fs.deleteDirectory(appResourcesDirectoryPath); |
There was a problem hiding this comment.
We could use this clean up too.
KristianDD
approved these changes
Apr 10, 2019
|
We discussed and agreed on all comments in private conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].