Skip to content

chore: remove projectTemplate logic #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

chore: remove projectTemplate logic #4517

merged 1 commit into from
Apr 10, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Apr 10, 2019

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Apr 10, 2019
@ghost ghost assigned Fatme Apr 10, 2019
@ghost ghost added new PR and removed cla: yes labels Apr 10, 2019
KristianDD
KristianDD approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@KristianDD KristianDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run smoke tests.

@Fatme Fatme force-pushed the fatme/remove-projectTemplate branch from 7d5e7d8 to 6054866 Compare April 10, 2019 10:15
@cla-bot cla-bot bot added the cla: yes label Apr 10, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Apr 10, 2019

test cli-smoke

@Fatme Fatme merged commit 7fb1752 into feature/webpack-only Apr 10, 2019
@Fatme Fatme deleted the fatme/remove-projectTemplate branch April 10, 2019 10:51
@ghost ghost removed the new PR label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristianDD KristianDD KristianDD approved these changes

Assignees

@Fatme Fatme

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fatme @KristianDD