chore: Merge release in master #3520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when productFlavors or split option is used in .gradle file more than on .apk files are produced. Print warning that will be used the last one produced from build.
Update CHANGELOG for 4.0.0rc
chore: Update CHANGELOG for 4.0.0rc
In case when produced Info.plist is not a binary file, `tns publish ios` command fails because `bplist-parser` is not able to parse non-binary plist files. This PR replaces `bplist-parser` module with `sample-plist` that is able to parse binary and non-binary files. Fixes #3470
Do not create empty .entitlements file
…rning Print warning when more than one package is produced from build
Fix (publish): Remove binary-plist and use simple-plist instead
Ora's definition files are not needed in production package, so move it as devDependency.
Introduce postCommandAction that is executed when the command succeeds. Use the action to print additional information to user how to continue after command is finished. Show some information on successful postinstall - instruct the users how to use local builds, cloud builds and playground.
…tions feat(commands): Introduce postCommandAction
fix: Move @types/ora as devDependency
Fix the help of `tns generate splashes` command as the content for `--background` option is incorrect.
docs: Fix the help of `tns generate splashes` command
Remove bufferpack dependency, as it is no longer user in CLI's code directly.
Remove bufferpack glob, as it is no longer user in CLI's code directly.
The properties-parser has been used years ago, to parse `.properties` files. We have not used this code since August 2015, so just remove the support for it. We have used it in AndroidProjectPropertiesManager, but this code is not used since the mentioned date, so remove it as well.
Remove filesize and progress-stream dependencies as they've been used only in a function that is never called. As the function implements interesting functionality, it is commented, not deleted. However, the dependencies are not used anywhere else, so they can be safely removed.
fix(deps): Remove dependencies that we do not use
When cloud build is used and iOS device does not have Developer Disk Image mounted, the logs are not visible. The problem is that the code fails to start/stop the application before starting the device log streams. Fix this by starting the logs before trying to start/stop the application.
fix(logs): Logs from iOS device are not shown on Windows
…lready installed. Fixes messages when console is non-interactive. Add `In case you have any issues, you can ask in our forum.` message when env is not configured after setup script. Refactor unit tests
…ocked fix(AppResources): try recover if resources update fails
…e-module-resolution Tdermendzhiev/add recursive module resolution
In cloud builds, when we try to prepare the project for iOS, sometimes we fail as the `cleanDestinationApp` does not pass correct arguments to `ensurePlatformInstalled` method. When we have cloud builds, the last argument should declare that the native prepartion should be skipped. When we do not pass it, the logic determines that the platform is not fully added and tries to add it again. The whole `platforms/ios` directory is deleted and then we try preparing the project again. At some point the code fails as there are missing files in the `platforms/ios` (we have deleted them). Pass the correct arguments, so the prepare will skip the native part in the mentioned case.
fix: Prepare for iOS with cloud builds fails on non macOS
fix (getting started): Improve behaviour when nativescript-cloud is installed
In case `xcrun simctl` throws some error, CLI does not handle it very well. Improve the logic in ios-sim-portable and update its version in order to resolve the issue.
Plamen5kov/fix plugin builds
fix: Incorrect error is shown when xcrun simctl is not configured
We are no longer using the cross clients analytics project, so delete the code that sends information to it.
The prompter for getting started changes fails in some cases, as we do not await the validation of the livesyncCommandHelper.validate call. So we try to execute some operations as we think the environment is setup correctly, but we are unable to do so and the code fails. Also add additional option to prompter in case cloud extension is installed. This gives better visibility of the feature
* Fix unit test * Show message that user can use forum or slack when manually setup is selected * Fix message when nativescript-cloud extension is installed
…-analytics-2 feat: Improve Getting started - add analytics
|
run ci |
Fatme
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Merge release in master