fix(deps): Remove dependencies that we do not use #3505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove bufferpack dependency, as it is no longer user in CLI's code directly.
Remove bufferpack glob, as it is no longer user in CLI's code directly.
The properties-parser has been used years ago, to parse `.properties` files. We have not used this code since August 2015, so just remove the support for it. We have used it in AndroidProjectPropertiesManager, but this code is not used since the mentioned date, so remove it as well.
Remove filesize and progress-stream dependencies as they've been used only in a function that is never called. As the function implements interesting functionality, it is commented, not deleted. However, the dependencies are not used anywhere else, so they can be safely removed.
Fatme
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some dependencies that we do not use anymore. Delete code that has not been used as well.
fix(deps): Remove bufferpack
Remove bufferpack dependency, as it is no longer user in CLI's code directly.
fix(deps): Remove glob …
Remove bufferpack glob, as it is no longer user in CLI's code directly.
fix(deps): Remove properties-parser
The properties-parser has been used years ago, to parse
.propertiesfiles. We have not used this code since August 2015, so just remove the support for it.We have used it in AndroidProjectPropertiesManager, but this code is not used since the mentioned date, so remove it as well. The usage has been added with this PR and removed in this PR
fix(deps): Remove filesize and progress-stream
Remove filesize and progress-stream dependencies as they've been used only in a function that is never called.
As the function implements interesting functionality, it is commented, not deleted. However, the dependencies are not used anywhere else, so they can be safely removed.
NOTE: Merge after telerik/mobile-cli-lib#1079