fix: Prepare for iOS with cloud builds fails on non macOS #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cloud builds, when we try to prepare the project for iOS, sometimes we fail as the `cleanDestinationApp` does not pass correct arguments to `ensurePlatformInstalled` method. When we have cloud builds, the last argument should declare that the native prepartion should be skipped. When we do not pass it, the logic determines that the platform is not fully added and tries to add it again. The whole `platforms/ios` directory is deleted and then we try preparing the project again. At some point the code fails as there are missing files in the `platforms/ios` (we have deleted them). Pass the correct arguments, so the prepare will skip the native part in the mentioned case.
Fatme
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cloud builds, when we try to prepare the project for iOS, sometimes we fail as the
cleanDestinationAppdoes not pass correct arguments toensurePlatformInstalledmethod.When we have cloud builds, the last argument should declare that the native prepartion should be skipped. When we do not pass it, the logic determines that the platform is not fully added and tries to add it again.
The whole
platforms/iosdirectory is deleted and then we try preparing the project again. At some point the code fails as there are missing files in theplatforms/ios(we have deleted them).Pass the correct arguments, so the prepare will skip the native part in the mentioned case.
PR Checklist
What is the current behavior?
Trying to build application for iOS with webpack in Sidekick leads to error.
What is the new behavior?
Correct arguments are passed and the application can be build with Sidekick.