feat(commands): Introduce postCommandAction #3501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
reviewed
Mar 27, 2018
lib/commands/post-install.ts
Outdated
| @@ -9,7 +9,7 @@ export class PostInstallCliCommand extends PostInstallCommand { | |||
| $settingsService: ISettingsService, | |||
| $doctorService: IDoctorService, | |||
| $analyticsService: IAnalyticsService, | |||
| $logger: ILogger) { | |||
| protected $logger: ILogger) { | |||
rosen-vladimirov
force-pushed
the
vladimirov/post-command-actions
branch
from
f5d33c7 to
8176817
Compare
Introduce postCommandAction that is executed when the command succeeds. Use the action to print additional information to user how to continue after command is finished. Show some information on successful postinstall - instruct the users how to use local builds, cloud builds and playground.
rosen-vladimirov
force-pushed
the
vladimirov/post-command-actions
branch
from
8176817 to
f9ef10b
Compare
tytodorov
approved these changes
Mar 28, 2018
rosen-vladimirov
changed the title
nadyaA
approved these changes
Mar 28, 2018
TsvetanMilanov
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce postCommandAction that is executed when the command succeeds.
Use the action to print additional information to user how to continue after command is finished.
Show some information on successful postinstall - instruct the users how to use local builds, cloud builds and playground.