fix(AppResources): try recover if resources update fails #3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosen-vladimirov @Pip3r4o |
rosen-vladimirov
suggested changes
Mar 28, 2018
| this.recover(originalAppResources, appResourcesDestination, appResourcesBackup); | ||
| this.$logger.out("Failed to update resources. They should be in their initial state."); | ||
| } catch (error) { | ||
| this.$logger.out(`Failed to update resources.${EOL} Backup of original content is inside "${appResourcesBackup}".${EOL}If "${originalAppResources} if missing copy from backup folder."`); |
There was a problem hiding this comment.
If "${originalAppResources} iS missing...
There was a problem hiding this comment.
Why don't we throw the original error here? Currently the command exits with code 0, as we've caught all errors, which is incorrect.
| this.recover(originalAppResources, appResourcesDestination, appResourcesBackup); | ||
| this.$logger.out("Failed to update resources. They should be in their initial state."); | ||
| } catch (error) { | ||
| this.$logger.out(`Failed to update resources.${EOL} Backup of original content is inside "${appResourcesBackup}".${EOL}If "${originalAppResources} if missing copy from backup folder."`); |
There was a problem hiding this comment.
Can you also add this.$logger.trace with the currently caught error?
KristianDD
force-pushed
the
kddimitrov/fix-resources-locked
branch
from
f464c6c to
07469fb
Compare
KristianDD
force-pushed
the
kddimitrov/fix-resources-locked
branch
from
07469fb to
23b06df
Compare
KristianDD
force-pushed
the
kddimitrov/fix-resources-locked
branch
from
23b06df to
dfa2df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3510