Brief accounting of eht-imaging and pycbc libraries. #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a few sentences about how packages from the scientific Python ecosystem were used in two examples: the direct image of the M87 supermassive blackhole (
eht-imaging
) and the discovery of gravitational waves (pycbc
).Per Stefan's suggestion, I focused mostly on the black hole imaging example and the
eht-imaging
package specifically. There are other repos from the EHT group that set up specific imaging pipelines to reproduce the final image (eht-imaging
is included of course) but they are a little harder to introspect. I focused most of my attention on theImage
class that is defined inehtim/image.py
as that seems to be pretty fundamental to the analysis. Of course,eht-imaging
is a library, and I can't guarantee that everything that is defined in the library was used in the specific analysis that produced the black hole image.I mostly focused on the uses of
numpy
,scipy
, andmatplotlib
, though there are other dependencies (scikit-image
,networkx
, andastropy
) that are included. A quick grepping showed thatnetworkx
was used for image comparisons,astropy
is used in quite a few places, primarily for I/O and time/coordinate transformations, and canny filters and Hough transforms fromscikit-image
are used in methods ofImage
.I tried to pack as much into as few sentences as I could so that you'd have an easy time cutting/re-wording down to what was important.
I also included the PyCBC example because I had taken a look at that previously. I'm happy to expand on it if you'd like, or feel free to ignore (N.B. I also modified
references.bib
for this section, so if you cut it out you can ignore the bib changes).Let me know if you want me to take a closer look or develop one or both of the examples further.