-
-
Notifications
You must be signed in to change notification settings - Fork 119
Fixes #gh-82 Draft of Black Hole case study content #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@joelachance, do we have any hugo theme shortcodes to help align and size images better? Also, are there any shortcakes for quote text - similar to how medium allows it? Say for e.g., https://github.com/parsiya/Hugo-Shortcodes |
@rgommers do you have any feedback for this case study? Is it good for merging? After noticing BIDS-numpy/numpy-paper#51 I am also wondering how best to utilise this work into our showcase (for gravitational waves as well as M87 imaging) Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually this looks pretty good, based on the screenshot. I can't get it to work locally though.
The text reads quite well to me. One thing to be careful about is that you name Katie/Andrew without emphasizing much that they were two people out of a much larger team. E.g., eht-imaging
has a number of contributors with a large number of commits, not just Andrew. Could you try to tweak that a little?
Sorry for the delay in reviewing @shaloo. The overall style, length and use of imagery is really nice I think - this is what we need from a case study I think. |
The gravitational waves part has been dropped again from that paper, the black hole part will stay in. I'd say feel free to take over any content and adapt the wording to make it fit in the case study. The info does give some more context into how NumPy and other libraries were used, so is useful. |
@rgommers - updated as suggested. Thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text shows up well now, but can't see figures
Merge branch 'master' of https://github.com/numpy/numpy.org into issu_82
This is how the page renders with Hugo on Mac OSX (catalina). I've tried to attribute credits to original image/diagram with links. Hope this addresses @rgommers inputs. thanks. ![Uploading Screenshot 2020-02-09 at 12.17.33 AM.png…]() |
Thanks for the fixes and screenshot @shaloo. It now works correctly for me. I switched machines but I think it was the actual changes here and not Hugo version. |
We'll want to remove the "Case Studies" link again when the tiles on the front page are merged I think, but for now it's useful: In it goes! Thanks @shaloo, this is great to have:) EDIT: oh no, hold on - there's a second case study in this same PR now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second case study looks pretty good! My one important comment is about the visualization part.
Yes, I struggled with #163 and then realised until BH one is merged GW can't go in - then thought of merging both to simplify first draft. Will refine in subsequent PRs when I add more CS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good now! All images look nice and are captioned with credits.
There's some room for polishing the text and probably would be useful if we'd ping some content matter experts for review of the astro/physics parts. But that can be done after merging, I'd like to get this in.
@shaloo the one thing I would like to see before merging is optimizing the included images for size. There's one of 2.2 MB and several more in the 0.5-1 MB range. It should be possible to compress them by a factor of a couple without losing resolution I'd think. Could you try that?
Done. |
Awesome, in it goes. Thanks @shaloo! |
Black Hole Case Study draft added
Deployed URL
http://numpy-<pr_number>.surge.sh/