Modified pycbc and eht-imaging text - more explicit. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've modified the text related to a more detailed look at the pycbc and eht-imaging libraries to be a bit more explicit. I also added the neutron star merger example to the end of the pycbc discussion as it is another incredible scientific discovery supported by GWOs and pycbc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #51 , I had not provided the same level of detail for the
networkxandastropydependencies as I did fornumpy,scipy, andmatplotlib. I've re-examined theeht-imagingcode in more detail and revised the wording in the paper to be a bit more explicit regarding these dependencies. The change is not strictly necessary, but I wanted to go back and ensure that the statements were as accurate as possible. The changes may include too much detail, but I wanted to make sure enough information was included for you to be able to make an informed decision about the appropriate level of detail.I've also added a reference to kilonova events, i.e. neutron star mergers, to the end of the
pycbcexample. The kilonova detection by GWOs (along with simultaneous confirmations from other types of observatories) is another hugely important scientific discovery (have you seen this version of the periodic table that highlights the origin of the elements - look at all the purple squares!) Feel free to remove if it makes the wording too clunky or the paragraph too long.