Skip to content

script to obtain eht-imaging dependency graph using pipdeptree and gr… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

shaloo
Copy link
Contributor

@shaloo shaloo commented Jul 6, 2019

…aphviz and highlight numpy role in M87 imaging

Screenshot 2019-07-06 at 8 01 24 PM

…aphviz and highlight numpy role in M87 imaging
@mattip
Copy link
Member

mattip commented Jul 6, 2019

welcome @shaloo (@shaloo is an applicant to the Google Season of Documents project, with the goal of improving our documentation).

Thanks for this, I never knew about pipdeptree and this is a nice view of how NumPy is at the base of many packages.

It is not clear to me how this will be worked into the NumPy documentation. Perhaps it should be part of numpy/numpy.org instead?

Edit: whoops, this is numpy.org

@rgommers
Copy link
Member

rgommers commented Jul 6, 2019

Yes indeed, this is the right repo. It was my suggestion to create a scripts dir, we can integrate it with the site content later on.

@rgommers
Copy link
Member

rgommers commented Jul 6, 2019

Very nice, thanks @shaloo. This figure tells a nice story:)

This script is a little dangerous, sourcing it when you have Python installed with Conda will let pip install numpy etc. from PyPI which has the potential to mess up the whole conda env. Can you please split the script in two, one for setting up a virtualenv, and one for creating the graph? That way it's explicit that the install is being done, and people can look at it more carefully and decide to install the dependencies some other way.

@shaloo
Copy link
Contributor Author

shaloo commented Jul 7, 2019

Thanks Matti and Ralf. Splitting it as suggested...

@shaloo
Copy link
Contributor Author

shaloo commented Jul 8, 2019

@rgommers , @mattip Updated as suggested - pls review and merge if ok. Thx.

@rgommers rgommers merged commit 5039339 into numpy:master Jul 8, 2019
@rgommers
Copy link
Member

rgommers commented Jul 8, 2019

Looks good to me, merged. Thanks again @shaloo!

rgommers added a commit to rgommers/numpy.org that referenced this pull request Jan 29, 2020
This is for the black hole case study. Created by Shaloo in numpygh-23,
it got lost when we renamed `master` to `old-sphinx-site`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants