-
Notifications
You must be signed in to change notification settings - Fork 415
Addition of switch_override feature to custom SB #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b2794d
to
6a82958
Compare
@vaughnbetz ready for review. |
|
@vaughnbetz @amin1377 I have added a test case for the diagonal wires. Also, here are the results of the titan_quick_qor. I did do a comparison of the rr_graph using the stratixiv arch and the directrf_stratixiv_arch_timing.blif (one of the larger tests). I can confirm that the two are equivalent and that this PR has not changed the rr_graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I suggest a few commenting changes. None affect functionality, so we can merge this and you can do the commenting changes in a separate PR if you prefer -- your call.
Looks like there are some conflicts to resolve too, so may as well make the commenting changes will fixing them. |
@vaughnbetz all merge conflicts and requests resolved. Ready to merge. |
@vaughnbetz CI is green, no conflicts, and all suggested changes have been implemented. Ready for merge. |
Description
This PR allows a user to specify a switch_override within the wireconn of a custom SB. The given switch will be used to override the wire_switch of the wire in the
to
set of the switch block. This PR will allow for more complicated wire shapes such as L and T shapes and provides the functionality needed to address issue #2043.Motivation and Context
Allows for more complicated wire types in architecture description. Will close #2043 by allowing for diagonal interconnect as well as more complicated wire structures.
How Has This Been Tested?
Many tests have been run on a variety of custom architectures to ensure that the functionality of switch_override works properly. Tests have also been conducted to ensure that this new functionality does not interfere with older architectures.
I plan to update the Xilinx arch in #2053 to test diagonal wires after we have gotten different x/y channel distributions figured out with custom SB's.
Types of changes
Checklist: