cleaned up implementation and formatted code

Author: WhiteNinjaZ

Makefile

@@ -17,7 +17,7 @@
 #    release		#Build with compiler optimization
 #    debug			#Build with debug info and no compiler optimization
 #    strict			#Build VPR with warnings treated as errors
-BUILD_TYPE ?= debug
+BUILD_TYPE ?= release
 
 #Convert to lower case for consistency
 BUILD_TYPE := $(shell echo $(BUILD_TYPE) | tr '[:upper:]' '[:lower:]')

libs/libarchfpga/src/parse_switchblocks.cpp

@@ -41,16 +41,16 @@ using vtr::t_formula_data;
 /*---- Functions for Parsing Switchblocks from Architecture ----*/
 
 //Load an XML wireconn specification into a t_wireconn_inf
-t_wireconn_inf parse_wireconn(pugi::xml_node node, const pugiutil::loc_data& loc_data, const t_arch_switch_inf* Switches, int num_switches);
+t_wireconn_inf parse_wireconn(pugi::xml_node node, const pugiutil::loc_data& loc_data, const t_arch_switch_inf* switches, int num_switches);
 
 //Process the desired order of a wireconn
 static void parse_switchpoint_order(const char* order, SwitchPointOrder& switchpoint_order);
 
 //Process a wireconn defined in the inline style (using attributes)
-void parse_wireconn_inline(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* Switches, int num_switches);
+void parse_wireconn_inline(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* switches, int num_switches);
 
 //Process a wireconn defined in the multinode style (more advanced specification)
-void parse_wireconn_multinode(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* Switches, int num_switches);
+void parse_wireconn_multinode(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* switches, int num_switches);
 
 //Process a <from> or <to> sub-node of a multinode wireconn
 t_wire_switchpoints parse_wireconn_from_to_node(pugi::xml_node node, const pugiutil::loc_data& loc_data);
@@ -66,7 +66,7 @@ static void parse_comma_separated_wire_points(const char* ch, std::vector<t_wire
 static void parse_num_conns(std::string num_conns, t_wireconn_inf& wireconn);
 
 /* parse switch_override in wireconn */
-static void parse_switch_override(const char* switch_override, t_wireconn_inf& wireconn, const t_arch_switch_inf* Switches, int num_switches);
+static void parse_switch_override(const char* switch_override, t_wireconn_inf& wireconn, const t_arch_switch_inf* switches, int num_switches);
 
 /* checks for correctness of a unidir switchblock. */
 static void check_unidir_switchblock(const t_switchblock_inf* sb);
@@ -82,7 +82,7 @@ static void check_wireconn(const t_arch* arch, const t_wireconn_inf& wireconn);
 /*---- Functions for Parsing Switchblocks from Architecture ----*/
 
 /* Reads-in the wire connections specified for the switchblock in the xml arch file */
-void read_sb_wireconns(const t_arch_switch_inf* Switches, int num_switches, pugi::xml_node Node, t_switchblock_inf* sb, const pugiutil::loc_data& loc_data) {
+void read_sb_wireconns(const t_arch_switch_inf* switches, int num_switches, pugi::xml_node Node, t_switchblock_inf* sb, const pugiutil::loc_data& loc_data) {
     /* Make sure that Node is a switchblock */
     check_node(Node, "switchblock", loc_data);
 
@@ -97,31 +97,31 @@ void read_sb_wireconns(const t_arch_switch_inf* Switches, int num_switches, pugi
         SubElem = get_first_child(Node, "wireconn", loc_data);
     }
     for (int i = 0; i < num_wireconns; i++) {
-        t_wireconn_inf wc = parse_wireconn(SubElem, loc_data, Switches, num_switches); // need to pass in switch info for switch override
+        t_wireconn_inf wc = parse_wireconn(SubElem, loc_data, switches, num_switches); // need to pass in switch info for switch override
         sb->wireconns.push_back(wc);
         SubElem = SubElem.next_sibling(SubElem.name());
     }
 
     return;
 }
 
-t_wireconn_inf parse_wireconn(pugi::xml_node node, const pugiutil::loc_data& loc_data, const t_arch_switch_inf* Switches, int num_switches) {
+t_wireconn_inf parse_wireconn(pugi::xml_node node, const pugiutil::loc_data& loc_data, const t_arch_switch_inf* switches, int num_switches) {
     t_wireconn_inf wc;
 
     size_t num_children = count_children(node, "from", loc_data, ReqOpt::OPTIONAL);
     num_children += count_children(node, "to", loc_data, ReqOpt::OPTIONAL);
 
     if (num_children == 0) {
-        parse_wireconn_inline(node, loc_data, wc, Switches, num_switches);
+        parse_wireconn_inline(node, loc_data, wc, switches, num_switches);
     } else {
         VTR_ASSERT(num_children > 0);
-        parse_wireconn_multinode(node, loc_data, wc, Switches, num_switches);
+        parse_wireconn_multinode(node, loc_data, wc, switches, num_switches);
     }
 
     return wc;
 }
 
-void parse_wireconn_inline(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* Switches, int num_switches) {
+void parse_wireconn_inline(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* switches, int num_switches) {
     //Parse an inline wireconn definition, using attributes
     expect_only_attributes(node, {"num_conns", "from_type", "to_type", "from_switchpoint", "to_switchpoint", "from_order", "to_order", "switch_override"}, loc_data);
 
@@ -150,13 +150,13 @@ void parse_wireconn_inline(pugi::xml_node node, const pugiutil::loc_data& loc_da
 
     char_prop = get_attribute(node, "to_order", loc_data, ReqOpt::OPTIONAL).value();
     parse_switchpoint_order(char_prop, wc.to_switchpoint_order);
-    
+
     // parse switch overrides if they exist:
     char_prop = get_attribute(node, "switch_override", loc_data, ReqOpt::OPTIONAL).value();
-    parse_switch_override(char_prop, wc, Switches, num_switches);
+    parse_switch_override(char_prop, wc, switches, num_switches);
 }
 
-void parse_wireconn_multinode(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* Switches, int num_switches) {
+void parse_wireconn_multinode(pugi::xml_node node, const pugiutil::loc_data& loc_data, t_wireconn_inf& wc, const t_arch_switch_inf* switches, int num_switches) {
     expect_only_children(node, {"from", "to"}, loc_data);
 
     /* get the connection style */
@@ -170,7 +170,7 @@ void parse_wireconn_multinode(pugi::xml_node node, const pugiutil::loc_data& loc
     parse_switchpoint_order(char_prop, wc.to_switchpoint_order);
 
     char_prop = get_attribute(node, "switch_override", loc_data, ReqOpt::OPTIONAL).value();
-    parse_switch_override(char_prop, wc, Switches, num_switches);
+    parse_switch_override(char_prop, wc, switches, num_switches);
 
     size_t num_from_children = count_children(node, "from", loc_data);
     size_t num_to_children = count_children(node, "to", loc_data);
@@ -341,17 +341,16 @@ void read_sb_switchfuncs(pugi::xml_node Node, t_switchblock_inf* sb, const pugiu
     return;
 }
 
-static void parse_switch_override(const char* switch_override, t_wireconn_inf& wireconn, const t_arch_switch_inf* Switches, int num_switches){
-
+static void parse_switch_override(const char* switch_override, t_wireconn_inf& wireconn, const t_arch_switch_inf* switches, int num_switches) {
     // check to see if user did not specify a switch_override
     if (switch_override == std::string("")) {
         wireconn.switch_override_indx = DEFAULT_SWITCH; //Default
         return;
     }
 
     // iterate through the valid switch names in the arch looking for the requested switch_override
-    for(int i = 0; i < num_switches; i++){
-        if(0 == strcmp(switch_override, Switches[i].name)){
+    for (int i = 0; i < num_switches; i++) {
+        if (0 == strcmp(switch_override, switches[i].name)) {
             wireconn.switch_override_indx = i;
             return;
         }

libs/libarchfpga/src/physical_types.h

@@ -532,7 +532,7 @@ enum class e_sb_type {
 };
 
 constexpr int NO_SWITCH = -1;
-constexpr int DEFAULT_SWITCH = -2; 
+constexpr int DEFAULT_SWITCH = -2;
 
 /* Describes the type for a physical tile
  * name: unique identifier for type
@@ -1688,7 +1688,7 @@ struct t_wireconn_inf {
     std::vector<t_wire_switchpoints> to_switchpoint_set;               //The set of segment/wirepoints representing the 'to' set (union of all t_wire_switchpoints in vector)
     SwitchPointOrder from_switchpoint_order = SwitchPointOrder::FIXED; //The desired from_switchpoint_set ordering
     SwitchPointOrder to_switchpoint_order = SwitchPointOrder::FIXED;   //The desired to_switchpoint_set ordering
-    int switch_override_indx = NO_SWITCH;                              // index in switch array of the switch used to override wire_switch of the 'to' set.
+    int switch_override_indx = DEFAULT_SWITCH;                         // index in switch array of the switch used to override wire_switch of the 'to' set.
 
     std::string num_conns_formula; /* Specifies how many connections should be made for this wireconn.
                                     *

notes.txt

@@ -0,0 +1 @@
+non-configurable edges is the thing to search in vpr

vpr/src/route/build_switchblocks.cpp

@@ -985,10 +985,10 @@ static void compute_wireconn_connections(
             sb_edge.to_wire = to_wire;
 
             // if the switch override has been set, use that. Otherwise use default
-            if(wireconn_ptr->switch_override_indx != DEFAULT_SWITCH){
+            if (wireconn_ptr->switch_override_indx != DEFAULT_SWITCH) {
                 sb_edge.switch_ind = wireconn_ptr->switch_override_indx;
             } else {
-                sb_edge.switch_ind = to_chan_details[to_x][to_y][to_wire].arch_wire_switch(); 
+                sb_edge.switch_ind = to_chan_details[to_x][to_y][to_wire].arch_wire_switch();
             }
             VTR_LOGV(verbose, "  make_conn: %d -> %d switch=%d\n", sb_edge.from_wire, sb_edge.to_wire, sb_edge.switch_ind);