Skip to content

libs: arch: interchange: add basic device information #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2021
Merged

libs: arch: interchange: add basic device information #1925

merged 2 commits into from
Dec 2, 2021

Conversation

acomodi
Copy link
Collaborator

@acomodi acomodi commented Nov 26, 2021

Description

This PR adds basic support for the architecture reading:

  • Device
  • Layout
  • Switches

Motivation and Context

This is part of the FPGA Interchange support in VTR

How Has This Been Tested?

Catch2 testing framework

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool labels Nov 26, 2021
@mtdudek @acomodi
vpr: interchange: add device data reading
f79c714 
This PR adds basic support for the architecture reading:
  - Device
  - Layout
  - Switches

Signed-off-by: Alessandro Comodi <[email protected]>
Co-authored-by: Maciej Dudek <[email protected]>
Co-authored-by: Alessandro Comodi <[email protected]>
@acomodi acomodi force-pushed the acom/fpga-interchange-device-upstream branch from 9e2b66b to f79c714 Compare November 26, 2021 16:17
@acomodi acomodi mentioned this pull request Nov 29, 2021
Closed
7 tasks
tangxifan
tangxifan requested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acomodi Look o.k. on code changes. Just some clarification needed.

@acomodi acomodi requested a review from tangxifan November 30, 2021 11:29
@acomodi acomodi force-pushed the acom/fpga-interchange-device-upstream branch from e60e82f to a4226a0 Compare December 1, 2021 08:17
@acomodi
Copy link
Collaborator Author

acomodi commented Dec 2, 2021

All required comments were added and CI went green on all tests, merging.

@acomodi acomodi merged commit 5398adb into verilog-to-routing:master Dec 2, 2021
@acomodi acomodi deleted the acom/fpga-interchange-device-upstream branch December 2, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangxifan tangxifan tangxifan approved these changes

@vaughnbetz vaughnbetz Awaiting requested review from vaughnbetz

Assignees
No one assigned
Labels
libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acomodi @tangxifan @mtdudek