Skip to content

[$70]Implement backward compatibility for legacy challenge urls(v4) #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue May 28, 2020 · 44 comments
Closed

Comments

@sushilshinde
Copy link
Collaborator

sushilshinde commented May 28, 2020

Resolve legacy challenge ID(v4) to new Challenge ID (v5)

  1. Whenever there is a route request with legacy challenge ID https://<domain>/challenges/<legacyId>
    eg. https://www.topcoder.com/challenges/30108180

  2. Intercept route request and call https://<apidomain>/v5/challenges?legacyId=<legacy id>
    eg. https://api.topcoder.com/v5/challenges?legacyId=30108180

  3. Read id

id: "55cff8bd-c622-412d-9683-ed85398044f7",
legacyId: 30108180
  1. Change URL to https://<domain>/challenges/<id>
    eg. https://www.topcoder.com/challenges/55cff8bd-c622-412d-9683-ed85398044f7

  2. So any legacy URL will be served after v5 challenge API integration

PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

@sushilshinde sushilshinde changed the title Implement backward compatibility for legacy challenge ID(v4) [$70]Implement backward compatibility for legacy challenge ID(v4) May 28, 2020
@cagdas001 cagdas001 self-assigned this May 28, 2020
@sushilshinde
Copy link
Collaborator Author

sushilshinde commented May 28, 2020

@cagdas001 not open for pickup

@cagdas001
Copy link
Collaborator

You said so?

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

@sushilshinde
Copy link
Collaborator Author

Paste mistake sorry about that.

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30126939 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30126939 has been updated - it has been assigned to daga_sumit.

This is an automated message for crazyk via Topcoder X

@sushilshinde sushilshinde changed the title [$70]Implement backward compatibility for legacy challenge ID(v4) [$70]Implement backward compatibility for legacy challenge urls(v4) May 28, 2020
@lakshmiathreya lakshmiathreya added the P1 Urgent (resolve within 24 hours) label May 29, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30126939 has been updated - sr_jr has been unassigned.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

crazyk07 commented Jun 6, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30126939

This is an automated message for crazyk via Topcoder X

@SathyaJayabal
Copy link
Collaborator

@simranb86 @sushilshinde , sometimes the redirection does not work. Please see the attached video. We get the following error
Screenshot 2020-06-08 at 2 15 03 PM

redir.mov.zip

@SathyaJayabal SathyaJayabal reopened this Jun 8, 2020
@srjr19
Copy link
Contributor

srjr19 commented Jun 8, 2020

@SathyaJayabal works as expected, see attached

4435.mov.zip

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jun 8, 2020

@simranb86 , I know it works sometimes, but I did face this problem many times today. @sushilshinde too faced the issue. Even now I see this happening. Maybe we can observe this for some more time.
Screenshot 2020-06-08 at 3 05 03 PM
@simranb86 in the above screenshot, looks like redirection happens and then we get the error. I have encountered this problem also occasionally.

@lakshmiathreya
Copy link

the Challenge is not loading even for Admin user:
Screenshot 2020-06-08 at 3 10 05 PM

@SathyaJayabal
Copy link
Collaborator

Reducing the priority as this is an intermittent issue.

@SathyaJayabal SathyaJayabal added Intermittent P2 Important (resolve within 3 days) and removed P0 Critical (resolve within 4 hours) labels Jun 9, 2020
@srjr19
Copy link
Contributor

srjr19 commented Jun 9, 2020

@SathyaJayabal @sushilshinde did you guys had a chance to look at console if there are any errors there when you saw the issue?

@SathyaJayabal
Copy link
Collaborator

@simranb86 , there is some issue with the challenge details page at present, but I will try to get that information for you when the present issue is resolved (#4493)

@srjr19
Copy link
Contributor

srjr19 commented Jun 9, 2020

@simranb86 , there is some issue with the challenge details page at present, but I will try to get that information for you when the present issue is resolved (#4493)

Sure, @SathyaJayabal exactly my point, we are pushing so many changes, so might be backend is failing or some other fix due to which we started seeing the errors, redirect is fine. But since so many changes are being done, and after 2-3 days if things start failing, we shouldn't go back to old issue, as we have pushed so many changes and expecting a fix on top of that, wouldn't be fair. If you see the issue, plz open a new ticket with console logs, as I wasn't able to replicate again today.

@SathyaJayabal
Copy link
Collaborator

@simranb86, that would be the case for most tickets, but in this case we dint have much chance to try the redirection before we closed it. The issue started happening/was noticed after we started using the redirection feature a lot. I don't believe it is because of something else. But If you find that the fix requires extra effort than was originally in scope, we can always create a new ticket with appropriate payment. Please don't worry that any extra efforts will not be paid. Let us keep this under observation for a couple of days.

cc @sushilshinde

@srjr19
Copy link
Contributor

srjr19 commented Jun 10, 2020

@simranb86, that would be the case for most tickets, but in this case we dint have much chance to try the redirection before we closed it. The issue started happening/was noticed after we started using the redirection feature a lot. I don't believe it is because of something else. But If you find that the fix requires extra effort than was originally in scope, we can always create a new ticket with appropriate payment. Please don't worry that any extra efforts will not be paid. Let us keep this under observation for a couple of days.

cc @sushilshinde

Sure, let's first get it to state we can replicate. I just tried again (https://test-community-app.topcoder-dev.com/challenges/30056660), but in vain.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jun 10, 2020

@simranb86 , here is the screenshot with console error. I could replicate this even now.
More details: Chrome on mac os, incognito mode, without logging in.

Screenshot 2020-06-10 at 10 09 42 AM

@SathyaJayabal
Copy link
Collaborator

@simranb86
redir.mov.zip
Happening for logged in user too.
Screenshot 2020-06-10 at 10 15 15 AM

@srjr19
Copy link
Contributor

srjr19 commented Jun 10, 2020

@SathyaJayabal I cleared the cache and can replicate now. Let's wait for @sushilshinde to merge changes for #4383 since we have changed that API call now so I think this issue will be gone now.

@sushilshinde can you please help push changes for #4383 ?

@sushilshinde
Copy link
Collaborator Author

Yes will do today.

@SathyaJayabal
Copy link
Collaborator

tracking this in a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants