-
Notifications
You must be signed in to change notification settings - Fork 212
[$70]Implement backward compatibility for legacy challenge urls(v4) #4435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@cagdas001 not open for pickup |
You said so?
|
Paste mistake sorry about that. |
Contest https://www.topcoder.com/challenges/30126939 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30126939 has been updated - it has been assigned to daga_sumit. |
Contest https://www.topcoder.com/challenges/30126939 has been updated - sr_jr has been unassigned. |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30126939 |
@simranb86 @sushilshinde , sometimes the redirection does not work. Please see the attached video. We get the following error |
@SathyaJayabal works as expected, see attached |
@simranb86 , I know it works sometimes, but I did face this problem many times today. @sushilshinde too faced the issue. Even now I see this happening. Maybe we can observe this for some more time. |
Reducing the priority as this is an intermittent issue. |
@SathyaJayabal @sushilshinde did you guys had a chance to look at console if there are any errors there when you saw the issue? |
@simranb86 , there is some issue with the challenge details page at present, but I will try to get that information for you when the present issue is resolved (#4493) |
Sure, @SathyaJayabal exactly my point, we are pushing so many changes, so might be backend is failing or some other fix due to which we started seeing the errors, redirect is fine. But since so many changes are being done, and after 2-3 days if things start failing, we shouldn't go back to old issue, as we have pushed so many changes and expecting a fix on top of that, wouldn't be fair. If you see the issue, plz open a new ticket with console logs, as I wasn't able to replicate again today. |
@simranb86, that would be the case for most tickets, but in this case we dint have much chance to try the redirection before we closed it. The issue started happening/was noticed after we started using the redirection feature a lot. I don't believe it is because of something else. But If you find that the fix requires extra effort than was originally in scope, we can always create a new ticket with appropriate payment. Please don't worry that any extra efforts will not be paid. Let us keep this under observation for a couple of days. |
Sure, let's first get it to state we can replicate. I just tried again (https://test-community-app.topcoder-dev.com/challenges/30056660), but in vain. |
@simranb86 , here is the screenshot with console error. I could replicate this even now. |
@simranb86 |
@SathyaJayabal I cleared the cache and can replicate now. Let's wait for @sushilshinde to merge changes for #4383 since we have changed that API call now so I think this issue will be gone now. @sushilshinde can you please help push changes for #4383 ? |
Yes will do today. |
tracking this in a new issue |
Resolve legacy challenge ID(v4) to new Challenge ID (v5)
Whenever there is a route request with legacy challenge ID
https://<domain>/challenges/<legacyId>
eg.
https://www.topcoder.com/challenges/30108180
Intercept route request and call
https://<apidomain>/v5/challenges?legacyId=<legacy id>
eg.
https://api.topcoder.com/v5/challenges?legacyId=30108180
Read
id
Change URL to
https://<domain>/challenges/<id>
eg.
https://www.topcoder.com/challenges/55cff8bd-c622-412d-9683-ed85398044f7
So any legacy URL will be served after v5 challenge API integration
PR to
https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api
The text was updated successfully, but these errors were encountered: