[$40]Member Profile: Stats History- Rating history graph, Challenge URL is in incorrect format

[SathyaJayabal]

https://test-community-app.topcoder-dev.com/members/Standlove/details/?track=DEVELOP&subTrack=DESIGN
User: jcori/appirio1234

Mouse over on the Rating history graph data points and click on challenge name

Expected URL Format: https://test-community-app.topcoder-dev.com/challenges/018d629e-f550-4ed4-bedd-0972433de5ad
Actual URL Format: https://test-community-app.topcoder-dev.com/challenges/30000431
cc @lakshmiathreya
stats history.mov.zip

[SathyaJayabal]

Also applicable for other sub tracks

[crazyk07]

Contest https://www.topcoder.com/challenges/30126688 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[sushilshinde]

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

[crazyk07]

Contest https://www.topcoder.com/challenges/30126688 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

[sushilshinde]

@PrakashDurlabhji please PR in 8 hours

[PrakashDurlabhji]

@sushilshinde are we allowed to change member-api repo? as it may require change over that repo I will explain in detail in below comment with flow and propose solution in detail

[PrakashDurlabhji]

@sushilshinde

1. Each and every point on rating history graph represents following object as given in red box.

2. and "challengeId" field is used to construct the url on tooltip as mentioned in code

   community-app/src/shared/components/ProfilePage/Stats/HistoryGraph/index.jsx

   Line 253 in 97051bf

   href: getChallengeLink(d.challengeId),

3. we need 1 more additional field such as "id" or any name as we keep, in object we receive as highlighted in red box.

4. topcoder-react-lib require no changes because call is directly passed to member api repo without any manipulation of response as mentioned here.
   https://github.com/topcoder-platform/topcoder-react-lib/blob/47f435df2bae4894d74b9724b3a35db2f15a1754/src/services/members.js#L107

5. so now in member-api repo, we can see ES query is made which gives history array, also seed data can be seen here
   https://github.com/topcoder-platform/member-api/blob/800d857fc0e315a467c219d1157bc43ed61d85a1/src/scripts/seed-data.js#L135
   and Swagger defines properties which can be seen here https://github.com/topcoder-platform/member-api/blob/800d857fc0e315a467c219d1157bc43ed61d85a1/docs/swagger.yaml#L2079

so we need 1 more property in the object to solve this as I am aware v5 has introduced legacy object in challenge response. so am I allowed to change member-api repo? @urwithat

OR

Also, If above adding of a property is not possible, then is something else expected?
e.g

1. taking each challenge id, call getChallengeDetails and then pick id from it? and form the new property and merge it in each object respectively?

such a solution expected?

or if anything i am missing ? Kindly confirm I will make a PR immediately.

[PrakashDurlabhji]

@rootelement my previous comment

[sushilshinde]

@PrakashDurlabhji this call is failing

https://api.topcoder-dev.com/v5/challenges?perPage=50&page=1&status=Active&memberId=Standlove

can you please pass id instead of the handle?

[sushilshinde]

@rootelement @urwithat please help here

All stats are brought by this call
https://api.topcoder-dev.com/v3/members/Standlove/stats

Which returns only legacy challenge Ids (in challenge API v5 context).

In order to work this correctly, it has to return new IDs.

[PrakashDurlabhji]

@sushilshinde can you please pass id instead of the handle?

sure I will, can you please tell me on which page is it failing? this will give me more idea

[sushilshinde]

@PrakashDurlabhji check console

#4420 (comment)

[PrakashDurlabhji]

@sushilshinde your comment implemented in PR #4432

[sushilshinde]

Thanks @PrakashDurlabhji will merge later today

[sushilshinde]

@SathyaJayabal This issue will be resolved by #4435

@PrakashDurlabhji you will be paid for your efforts on this ticket

[PrakashDurlabhji]

@sushilshinde thanks

[SathyaJayabal]

verified on beta
example URL:
https://beta-community-app.topcoder.com/members/Standlove/details/?track=DEVELOP&subTrack=ASSEMBLY_COMPETITION
rating_hist.mov.zip

[crazyk07]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30126688

This is an automated message for crazyk via Topcoder X