Skip to content

[$50]Submission emails link you to old url #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmessing opened this issue Jul 7, 2020 · 14 comments
Closed

[$50]Submission emails link you to old url #4632

dmessing opened this issue Jul 7, 2020 · 14 comments

Comments

@dmessing
Copy link
Contributor

dmessing commented Jul 7, 2020

Describe the bug
Make a submission on beta

To Reproduce
Check your mail.

Expected behavior
Email link should go to a GUID I believe?

Screenshots

Hi mess, Thanks for submitting to Reclamation Streamflow Forecasting Design Challenge.  We received your submission and are processing it. You will see additional notifications as we perform reviews on your submission.   Please return to the challenge if you would like to submit again or ask any questions.  Thank You,The Topcoder Team

sample link: http://link.topcoder.com/ls/click?upn=IFhsZa7iQd2f2LUSLudQKL6PwntVD9sOtH3-2BVL-2B4rEWXQ9hEQERkQN02yYjoR9K1mfTqAcFy9w10RdF-2F21RD3w-3D-3DLS4-_T6e0x-2FPqg3OFdoYLQG6BsDV4k3WWUkFNAlATrtR1AlCvcB9dfUtCIm2yAkPbpfcka2diMwHcNFxvLR7uk4Ow2iH9knKc4yZdAHdSctAq4ONhfLZ5JjuayAX-2BpBF3kmTfGYXCm31J7gtesUe1UyEkaiLkq3sGa0c9BoPJp5twxErKJXfY7PZ4T1ln41rY88-2BUIfyqQ9-2B87uhCP4DSprNdllryTJ8Way7y3NT0pYw1T00-3D

http://link.topcoder.com/ls/click?upn=IFhsZa7iQd2f2LUSLudQKL6PwntVD9sOtH3-2BVL-2B4rEWXQ9hEQERkQN02yYjoR9K1mfTqAcFy9w10RdF-2F21RD3w-3D-3DMBw3_T6e0x-2FPqg3OFdoYLQG6BsDV4k3WWUkFNAlATrtR1AlCvcB9dfUtCIm2yAkPbpfcka2diMwHcNFxvLR7uk4Ow2r835spyOKyVIPyik2-2ByOJO0mrHh8UufiHB-2BhoeaCZT7XAk3mPDT-2B2pcVSY6K8ts-2BRSu7uJFy2KKX-2F3zC97eNfLkhLGW283O5d6Ieegyllh9C92dbRhPxNdPPEIMG-2F85RG1BJhsOmlb4geGKgzhrNOY-3D

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Oanh-and-only-Oanh
Copy link

@sushilshinde
Copy link
Collaborator

@Oanh-and-only-Oanh this is should be opened on submission ali as well.

@SathyaJayabal
Copy link
Collaborator

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jul 8, 2020

topcoder-platform/submissions-api#189 (comment)

@callmekatootie @sushilshinde @rootelement @dushyantb
Please provide any suggestions on where to solve this issue?

cc @lakshmiathreya

@sushilshinde
Copy link
Collaborator

@callmekatootie

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jul 10, 2020

@sushilshinde , both the submission and registration confirmation emails have the legacy id in the challenge details URL.

  1. Registration Confirmation Email:

Screenshot 2020-07-10 at 2 39 57 PM

Sample link "https://www.topcoder.com/challenges/30132287/submit/"
Here we have the submit attached to the url (to take the user to the submissions page), so the link is not automatically redirected to the new url with UUID

example:
https://beta-community-app.topcoder.com/challenges/30132287/submit does not redirect to https://beta-community-app.topcoder.com/challenges/3cfa4e31-1758-4e65-aa73-61caa1d5154f/submit

  1. Submission confirmation email
Hi picachui, Thanks for submitting to Adobe COVID Challenge Series - Use Case 1: Consumption of Public Information Measurement and Analysis.  We received your submission and are processing it. You will see additional notifications as we perform reviews on your submission.   Please return to the challenge if you would like to submit again or ask any questions.  Thank You,The Topcoder Team |   | Hi picachui, Thanks for submitting to Adobe COVID Challenge Series - Use Case 1: Consumption of Public Information Measurement and Analysis.  We received your submission and are processing it. You will see additional notifications as we perform reviews on your submission.   Please return to the challenge if you would like to submit again or ask any questions.  Thank You,The Topcoder Team

Sample link:
http://link.topcoder.com/ls/click?upn=IFhsZa7iQd2f2LUSLudQKL6PwntVD9sOtH3-2BVL-2B4rEWXQ9hEQERkQN02yYjoR9K1VyYuZyml56OUm2UxaTljwQ-3D-3D1X7P_Scb-2FZNd3cGqcdXY-2FFbVYYYV-2F64zJcoX-2Bk21g9ydEZ6r0JIvxFwQTy4xU6T3vURMtWGRh1V5GbjjNZi4bcPS30CRscahnq9JYHP5Tas-2B-2F0Goh6xHk7aLFTcRhmQZgt7YX5LV17-2BVdJP2P4n9Sq89b9OfRwuCrDVCb0d91YIHXY20mWFX1GdyW35g-2BZm2fVfxUFBnJ0zZFfc5HhPmolFr1sMX9dPqBoc7kLzlxD4ECmcM-3D

This link translates to "https://www.topcoder.com/challenges/30132287" which should automatically be redirected to the new UUID URL.

Example https://beta-community-app.topcoder.com/challenges/30132287 redirects to https://beta-community-app.topcoder.com/challenges/3cfa4e31-1758-4e65-aa73-61caa1d5154f

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 13, 2020

@SathyaJayabal got the point. We need to provide backward compatibility in FE and backend also needs to change email content.

https://www.topcoder.com/challenges/<legacyID>/submit/ to https://www.topcoder.com/challenges/<UUID>/submit/

@sushilshinde sushilshinde changed the title Submission emails link you to old url [$50]Submission emails link you to old url Jul 13, 2020
@sushilshinde sushilshinde added P0 Critical (resolve within 4 hours) Submission Page tcx_OpenForPickup labels Jul 13, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30132709 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

Provide backward compatibility to the legacy email link

  1. Whenever there is a route request with legacy challenge ID https://www.topcoder.com/challenges/<legacyID>/submit/
  2. Intercept route request and call https://<apidomain>/v5/challenges?legacyId=<legacy id>
  3. Read id
id: "55cff8bd-c622-412d-9683-ed85398044f7",
legacyId: 30108180
  1. Change URL to https://www.topcoder.com/challenges/<UUID>/submit/
  2. So any legacy URL will be served after v5 challenge API integration
  3. This has already been done - Reference fix: [$70]Implement backward compatibility for legacy challenge urls(v4) #4435

PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

#4435

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30132709 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) and removed P0 Critical (resolve within 4 hours) Must-fix-before-v5-release labels Jul 13, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added P2 Important (resolve within 3 days) and removed P3 Normal (resolved within 7 days) labels Aug 11, 2020
@SathyaJayabal SathyaJayabal added this to the V5 Challenge API v1.1 milestone Aug 13, 2020
@luizrrodrigues
Copy link
Collaborator

@sushilshinde PR ready ☝️

@lakshmiathreya
Copy link

Screenshot 2020-08-20 at 5 56 47 PM

Screenshot 2020-08-20 at 5 51 54 PM

@lakshmiathreya
Copy link

The Legacy Id based submission url in the Registration email is redirected to UUID one as expected.

@lakshmiathreya lakshmiathreya added the QA Pass in PROD Passed verification on Production label Aug 24, 2020
@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30132709

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants