Skip to content

Implement backward compatibility for legacy challenge urls(v4) - Sometimes redirection does not work #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 11, 2020 · 8 comments
Labels
Intermittent P2 Important (resolve within 3 days) v5-intgration-sub-code

Comments

@SathyaJayabal
Copy link
Collaborator

#4435 (comment)

example:https://test-community-app.topcoder-dev.com/challenges/30056660

@SathyaJayabal SathyaJayabal added Intermittent P2 Important (resolve within 3 days) v5-intgration-sub-code labels Jun 11, 2020
@srjr19
Copy link
Contributor

srjr19 commented Jun 11, 2020

@SathyaJayabal @sushilshinde as per last comment, this seems now fixed - just tested on test env several times and it redirects fine https://test-community-app.topcoder-dev.com/challenges/30056660 .

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , please hold off on opening this for pickup until we can verify if this is already fixed in the latest deployment.

cc: @simranb86

@lakshmiathreya
Copy link

Seems intermittent - Screenshot 2020-06-11 at 4 55 11 PM

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde @simranb86 , we still face the issue.
Screenshot 2020-06-11 at 4 57 14 PM

Screenshot 2020-06-11 at 4 54 33 PM

@srjr19
Copy link
Contributor

srjr19 commented Jun 12, 2020

@SathyaJayabal @sushilshinde here is root cause of the problem. So once we fix #4505 , this intermedittent will be fixed. If you want I can try to push a fix for #4505 today ? Feel free to assign that to me if other developer cannot fix it and then let's see how it fix goes about it.

issue_ 4515

Else the backward compatibility redirect is working great.

@sushilshinde
Copy link
Collaborator

@simranb86 do we need review types for no-auth calls?

@srjr19
Copy link
Contributor

srjr19 commented Jun 15, 2020

@simranb86 do we need review types for no-auth calls?

@sushilshinde no review types is auth based call. I guess that is reason why we say animation forever in other ticket also - I have pushed one PR to make sure we check for auth before making call to challenge-api. That change should also fix #4505

If you are checking like should we make that reviewTypes call as no auth on challenge-api side, then yes, we can as it has no security data or risk.

Let's revisit once that PR is merged.

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde, issue is not observed now.
cc @lakshmiathreya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Intermittent P2 Important (resolve within 3 days) v5-intgration-sub-code
Projects
None yet
Development

No branches or pull requests

4 participants