-
Notifications
You must be signed in to change notification settings - Fork 212
Implement backward compatibility for legacy challenge urls(v4) - Sometimes redirection does not work #4515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@SathyaJayabal @sushilshinde as per last comment, this seems now fixed - just tested on test env several times and it redirects fine https://test-community-app.topcoder-dev.com/challenges/30056660 . |
@sushilshinde , please hold off on opening this for pickup until we can verify if this is already fixed in the latest deployment. cc: @simranb86 |
@sushilshinde @simranb86 , we still face the issue. |
@SathyaJayabal @sushilshinde here is root cause of the problem. So once we fix #4505 , this intermedittent will be fixed. If you want I can try to push a fix for #4505 today ? Feel free to assign that to me if other developer cannot fix it and then let's see how it fix goes about it.
|
@simranb86 do we need review types for no-auth calls? |
@sushilshinde no review types is auth based call. I guess that is reason why we say animation forever in other ticket also - I have pushed one PR to make sure we check for auth before making call to challenge-api. That change should also fix #4505 If you are checking like should we make that reviewTypes call as no auth on challenge-api side, then yes, we can as it has no security data or risk. Let's revisit once that PR is merged. |
@sushilshinde, issue is not observed now. |
#4435 (comment)
example:https://test-community-app.topcoder-dev.com/challenges/30056660
The text was updated successfully, but these errors were encountered: