Skip to content

[$50]Member Profile: Stats History #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue May 19, 2020 · 18 comments
Closed

[$50]Member Profile: Stats History #4383

SathyaJayabal opened this issue May 19, 2020 · 18 comments

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented May 19, 2020

accessing the stats history page displays error "Failed to get member active challenges"
https://test-community-app.topcoder-dev.com/members/dan_developer/details/?track=DEVELOP&subTrack=CODE
Screenshot 2020-05-19 at 6 40 50 PM

@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) Test Env Environment v5-intgration-sub-code labels May 19, 2020
@sushilshinde sushilshinde changed the title Member Profile: Stats History [$50]Member Profile: Stats History May 22, 2020
@SathyaJayabal SathyaJayabal added Member Profiles P2 Important (resolve within 3 days) and removed P3 Normal (resolved within 7 days) labels May 22, 2020
@sushilshinde
Copy link
Collaborator

@ThomasKranitsas probably related to
#4384

@Oanh-and-only-Oanh Oanh-and-only-Oanh added P1 Urgent (resolve within 24 hours) and removed P2 Important (resolve within 3 days) labels May 26, 2020
@SathyaJayabal
Copy link
Collaborator Author

@ThomasKranitsas ,can we have an ETA for this ticket please?

@ThomasKranitsas
Copy link
Contributor

This issue is because we're passing the user handle as memberId instead of the user ID.
Should we update the react lib to:

  • Call the members API to fetch the user ID?
  • Call the challenges API using the user ID from the above call?

cc @sushilshinde @rootelement

@SathyaJayabal SathyaJayabal added the Need clarification Need clarification to proceed fixing the issue further label May 28, 2020
@sushilshinde
Copy link
Collaborator

@sushilshinde sushilshinde added tcx_OpenForPickup and removed Need clarification Need clarification to proceed fixing the issue further labels Jun 2, 2020
@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

@crazyk07
Copy link

crazyk07 commented Jun 2, 2020

Contest https://www.topcoder.com/challenges/30127639 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@rashmi73 rashmi73 self-assigned this Jun 2, 2020
@crazyk07
Copy link

crazyk07 commented Jun 2, 2020

Contest https://www.topcoder.com/challenges/30127639 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 2, 2020

@sushilshinde we are passing userid as of now in call, whereas I feel memberId should be sent.

but i do not find "memberId" in state.profile.info object, hence it is required

console shows no error.

@sushilshinde
Copy link
Collaborator

@rashmi73 please share API call examples

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 4, 2020

@sushilshinde apology for delay

@srjr19
Copy link
Contributor

srjr19 commented Jun 7, 2020

being discussed with @rootelement over slack for the API call to use, as none available right now, as per my knowledge

@srjr19
Copy link
Contributor

srjr19 commented Jun 9, 2020

@sushilshinde PRs for the same

Note also changed logic for User Challenges loading so it is faster now with less calls going in so this should also fix #4491 - @SathyaJayabal please help verify both once the changes are merged and deployed.

@sushilshinde
Copy link
Collaborator

@simranb86 please raise topcoer react lib PR again.

I had to revert it for some other reason

@srjr19
Copy link
Contributor

srjr19 commented Jun 9, 2020

@simranb86 please raise topcoer react lib PR again.

I had to revert it for some other reason

@sushilshinde Kindly help merge and deploy these

@srjr19
Copy link
Contributor

srjr19 commented Jun 11, 2020

new PR #4514

@SathyaJayabal
Copy link
Collaborator Author

verified on test and beta
Screenshot 2020-06-11 at 2 37 20 PM
Screenshot 2020-06-11 at 2 43 13 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30127639

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants