Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

ResourceBookings Edit UI #56

Closed
wdprice opened this issue Jan 18, 2021 · 11 comments
Closed

ResourceBookings Edit UI #56

wdprice opened this issue Jan 18, 2021 · 11 comments

Comments

@wdprice
Copy link

wdprice commented Jan 18, 2021

Implement a UI for viewing details & editing resourceBooking records that exist on a project. Use same design language as using the Job edit page

This area of the page contains the resourceBookings:
image

Edit Feature should only be available to Admins.

Fields to display:

  • Job Title (READ ONLY) - pulled from related job record
  • Assigned Resource (READ ONLY) - handle of Topcoder member assigned
  • Start Date -
  • End Date -
  • Client Rate - customer rate field
  • Member Rate - member rate field (ONLY VISIBLE TO ADMINS - do not show to customer in any form)
@wdprice wdprice added the enhancement New feature or request label Jan 18, 2021
@maxceem
Copy link
Contributor

maxceem commented Jan 21, 2021

Sum up

  • Add option "Edit" to "Actions" menu.
  • It should lead to the resource booking editing page /taas/myteams/{teamId}/rb/{resourceBookingId}/edit.
  • This page should have a design similar to Job Editing Page https://marvelapp.com/prototype/921gg0f/screen/75360460/handoff
  • This form should have the next fields:
    • Job Title (READ ONLY) - pulled from related job record
    • Assigned Resource (READ ONLY) - handle of Topcoder member assigned
    • Start Date (with calendar widget)
    • End Date (with calendar widget)
    • Client Rate (input allows positive float numbers)
    • Member Rate (input allows positive float numbers)
  • There would be NO view page, only edit page unlike for jobs.

Questions

  1. Should we also allow editing "status" and "rateType"?

@wdprice
Copy link
Author

wdprice commented Jan 21, 2021

I agree on your statements above.

I originally intended to allow a VIEW and EDIT, however the entirety of the data is displayed on "Team Detail" so there is no reason to have both. I like having the "Edit" option appear in the actions drop-down.

EDIT should only visible to admin users (role discussion pending still).

@maxceem
Copy link
Contributor

maxceem commented Jan 25, 2021

Yes, we should edit "status" as per the discussion.

maxceem added a commit that referenced this issue Feb 8, 2021
@maxceem
Copy link
Contributor

maxceem commented Feb 8, 2021

This is ready for QA on DEV except for a few things:

Not yet done:

  • "Member Rate" is shown to all the users. And edit button is shown to all the users. This would be done after implementing Project Access Management Controls Project Access Management Controls #14

@SathyaJayabal
Copy link
Collaborator

@maxceem , getting a loading page when clicking on resource name. Resource booking details page is not displayed.

example:
https://platform.topcoder-dev.com/taas/myteams/16926/rb/a8b9fda7-df1c-4fe2-ba4b-b76142ece345
user:tonyj
Screenshot 2021-02-08 at 5 53 36 PM

@sandhiyakavi
Copy link
Collaborator

@maxceem Able to view the Resource booking details now. Below are some of the issues found

  1. FE showing error if the Member Rate is a decimal value but we are able to give decimal values through api. Is Member rate needs to be a whole number?
    image

  2. Able to set End date less than the Start date.

image

@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

@sandhiyakavi I've created separate issues for easier control. Could we mark this issue as QA passed, and we would handle not yet fixed issues separately?

@sandhiyakavi
Copy link
Collaborator

Issue #85 created for tracking #56 (comment)

@maxceem
Copy link
Contributor

maxceem commented Feb 22, 2021

@wdprice at the moment in UI we are always saying "Member Details" instead of the "Resource Bookings":

image

Should update these text to distinguish resource bookings from Project/Team members which we can manage on the access page to?

  • Resource Booking
  • Edit Resource Booking

@wdprice
Copy link
Author

wdprice commented Feb 22, 2021 via email

maxceem added a commit that referenced this issue Feb 23, 2021
@sandhiyakavi
Copy link
Collaborator

Fixed: 🆗 in Production via milestone v1.5

Able to view the Resource bookings page.

image

@lakshmiathreya Need to test Resource Booking edit using Booking Manager/Admin role.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants