[$60] ResourceBookings Edit UI: Should show related Job name

[maxceem]

Follow up from #56 (comment)

getting a loading page when clicking on resource name. Resource booking details page is not displayed.
example:
https://platform.topcoder-dev.com/taas/myteams/16926/rb/a8b9fda7-df1c-4fe2-ba4b-b76142ece345
user:tonyj

This issue in some way happens to both pages:

• view: https://platform.topcoder-dev.com/taas/myteams/16926/rb/a8b9fda7-df1c-4fe2-ba4b-b76142ece345

• edit: https://platform.topcoder-dev.com/taas/myteams/16926/rb/a8b9fda7-df1c-4fe2-ba4b-b76142ece345/edit:

  

This happens because both these pages are implemented incorrectly.

Both these pages are trying to show information from the Candidate instead of the Job Name:

• view source code: https://github.com/topcoder-platform/taas-app/blob/dev/src/routes/ResourceBookingDetails/index.jsx#L24

• edit source code: https://github.com/topcoder-platform/taas-app/blob/dev/src/routes/ResourceBookingForm/index.jsx#L39-L41

• We don't need to to get candidates data for these pages.

• We only need to show the Job Name on both of these pages.

• Update the logic there so we only are loading the Job using jobId which is defined in the resource. And there should not be any logic for Candidate.

• Note, that jobId might be null in the resource, in such case instead of the Job Name show text <Not Assigned>.

• When page is loading wait until job data is loaded before showing the page. So we would see the page already with Job Name. But keep in mind that maybe there is not Job, then the page should be shown without Job Name and don't wait Job loading.

• Make the logic clear for all of this.

• Provide a link for testing, when there is not Job assigned to the resource.

• It is preferable to use hook useAsync instead of useData for loading data on both of these pages. I also think that with hook useAsync it would be easier to implement the logic for waiting for Job loading together with getReourceBookingById. (This is not a mandatory requirement though).

[maxceem]

Challenge https://www.topcoder.com/challenges/88578d52-3659-404f-9fac-b58bec815c62 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[dashu-baba]

@bug-bash-helper assign

[bug-bash-hunt-helper]

@dashu-baba ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[maxceem]

Challenge https://www.topcoder.com/challenges/88578d52-3659-404f-9fac-b58bec815c62 has been assigned to nowshad.bappy.

This is an automated message for maxceem via Topcoder X

[dashu-baba]

@bug-bash-helper unassign

[bug-bash-hunt-helper]

@dashu-baba ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

[maxceem]

Challenge https://www.topcoder.com/challenges/88578d52-3659-404f-9fac-b58bec815c62 nowshad.bappy has been unassigned.

This is an automated message for maxceem via Topcoder X

[yoution]

@bug-bash-helper unassign

[bug-bash-hunt-helper]

@yoution 🛑 I cannot unassign you from this issue because you are not assigned.

[yoution]

@bug-bash-helper assign

[bug-bash-hunt-helper]

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[maxceem]

Challenge https://www.topcoder.com/challenges/88578d52-3659-404f-9fac-b58bec815c62 has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

[sandhiyakavi]

@maxceem Resource booking page both View and Edit are not displaying sometimes and getting displayed sometimes. It seems like a intermittent issue. Below are some of the issues I noted.

1. url: https://platform.topcoder-dev.com/taas/myteams/16928/rb/2423288f-aa53-4183-bc33-2d6c5b767189
   

After refresh ,the page is displayed Also the Job name was different.

2. Same issue for this, but title name is good
   url: https://platform.topcoder-dev.com/taas/myteams/17093/rb/6f52099b-9b9b-43f6-ab58-0cb17692c904
   
   Displayed after refresh
   

3. RB Edit page.
   

[maxceem]

@sandhiyakavi 1 & 2 are fixed by ee297cb. 3 was already fixed by 7d037b7 (note, that issue 3 has been reproducible on each time, it got broken during one of the previous fix).

Regarding showing <Not Found> 123-23-234-234-234-12123 this is due to inconsistent data. This means that the Job to which RM was assigned is removed now.

Ready for QA now.

[sandhiyakavi]

Verified on Dev Env. Working as expected.

1. RB with Job available.

bandicam.2021-02-19.19-17-00-770.mp4

2. RB with Job not assigned.

bandicam.2021-02-19.19-18-08-554.mp4

3. RB with Job removed.

bandicam.2021-02-19.19-19-05-279.mp4

[maxceem]

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

[maxceem]

Payment task has been updated: https://www.topcoder.com/challenges/88578d52-3659-404f-9fac-b58bec815c62
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 88578d52-3659-404f-9fac-b58bec815c62 has been paid and closed.

This is an automated message for maxceem via Topcoder X

[codejamtc]

@lakshmiathreya

[lakshmiathreya]

@sandhiyakavi as discussed pls add the latest screenshots of this screen from Dev - seems like it has changed ...

[sandhiyakavi]

@maxceem The title for the Resource booking view and Edit page has been changed from "Member Details" and "Edit Member Details" to "Resource Booking" and "Edit Resource Booking" in Dev as well as Prod. Is it expected? Because I was not able to find an issue logged related to this.

[maxceem]

yes, @sandhiyakavi it's expected, I've confirmed it with Will here #56 (comment)