[$50] ResourceBookings Edit UI: validation rules

[maxceem]

Follow up from: #56 (comment)

1. If the Member Rate is a decimal value it is showing validation error. But we are able to give decimal values through API. So we have to fix UI validation and allow decimal numbers

   

2. Show validation error if we enter start date after end date, or end date after start date:

   • Start Date should not be after End Date

     

   • The error should have the same style as "title" error in Job Edit page

   

   • We can show it under each field if it's easier:

     • Start Date should not be after End Date
     • End Date should not be before Date

   • "Start Date" === "End Date" is allowed

[maxceem]

Challenge https://www.topcoder.com/challenges/1a3c6e3d-d552-40aa-ae15-38db93311a28 has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[dashu-baba]

@bug-bash-helper assign

[bug-bash-hunt-helper]

@dashu-baba ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

[maxceem]

Challenge https://www.topcoder.com/challenges/1a3c6e3d-d552-40aa-ae15-38db93311a28 has been assigned to nowshad.bappy.

This is an automated message for maxceem via Topcoder X

[dashu-baba]

Ready for Review": "@bug-bash-helper {https://github.com/topcoder-platform/taas-app/pull/96} is ready for review

[bug-bash-hunt-helper]

@dashu-baba ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

[dashu-baba]

Okay I will update accordingly.

[dashu-baba]

@bug-bash-helper #96 is ready for review

[bug-bash-hunt-helper]

@dashu-baba ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

[maxceem]

The payment for this task is increased to $50. But we would like to have a solution that properly utilizes Final Form features without workarounds.

[sandhiyakavi]

@maxceem If we made any changes in the Resource Booking, the changes are getting saved but we are not able to open the Edit Resource booking page again. It's loading continuously.
sample: "https://platform.topcoder-dev.com/taas/myteams/17091/rb/5f43acbf-9b90-4fd2-87e9-03ddbfafcc7d/edit"

issue.85.mp4

2. For End Date < Start Date , Can we show a single validation message? The message under End Date field is taking two lines.
   

[maxceem]

@maxceem If we made any changes in the Resource Booking, the changes are getting saved but we are not able to open the Edit Resource booking page again. It's loading continuously.
sample: "https://platform.topcoder-dev.com/taas/myteams/17091/rb/5f43acbf-9b90-4fd2-87e9-03ddbfafcc7d/edit"

@sandhiyakavi this is fixed now. It was another issue which I've just merged #90

For End Date < Start Date , Can we show a single validation message? The message under End Date field is taking two lines.

If you edit only one field it would show only one error for that field. But if you edit 2 fields, then it would show this error for 2 fields, because actually, we can fix this error by editing any of these fields, not only one of them. If user edits 2 fields we don't know which of the fields user has to fix that's why error is showing for both.

The message under End Date field is taking two lines.

I've fixed so it is showing good on desktop screen:

But on smaller screens, there might be not enough space, so it would be shown 2 lines anyway:

[sandhiyakavi]

Verified on Dev Env.Working as expected.

Able to open the Edit Resource Booking page after saving the changes.The Member rate field is allowing the decimal point values.

RB_rules.mp4

Start Date and End Date validation messages are displayed correctly. Also able to save if Start Date===End Date

[maxceem]

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

[maxceem]

Payment task has been updated: https://www.topcoder.com/challenges/1a3c6e3d-d552-40aa-ae15-38db93311a28
Payments Complete
Winner: nowshad.bappy
Copilot: maxceem
Challenge 1a3c6e3d-d552-40aa-ae15-38db93311a28 has been paid and closed.

This is an automated message for maxceem via Topcoder X

[sandhiyakavi]

@lakshmiathreya Need to check this issue with Booking Manager/Admin role. Below features needs to be tested in edit Resource Booking page,

1. Change member rate as a floating point numbers and save.
2. Check by changing start date greater than End date, validation message "Start Date should not be after End Date" shown.
3. Check by changing end date lesser than Start date, validation message "End Date should not be before Date" shown.
4. If Start Date ===End Date, able to save.
5. Check whether able to open the Edit Resource booking page after making changes.