Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Jobs Edit UI #12

Closed
wdprice opened this issue Dec 2, 2020 · 20 comments
Closed

Jobs Edit UI #12

wdprice opened this issue Dec 2, 2020 · 20 comments

Comments

@wdprice
Copy link

wdprice commented Dec 2, 2020

Implement a UI for viewing & editing the details on a job from the Team Details page.

Must be able to view:
All fields except memberRate and system fields (createdBy, createdTime, externalID, etc.)

Must be able to edit:

Job Name
Job Description
Number of Openings
Job Skills

Only someone with access to the project can edit a a related job record, or TC admins.

@wdprice wdprice added the enhancement New feature or request label Dec 2, 2020
@maxceem
Copy link
Contributor

maxceem commented Dec 2, 2020

Should we also be able to create new jobs from UI?

@wdprice
Copy link
Author

wdprice commented Dec 2, 2020

Undecided at this time, but it won't be in until a later release if so, and we will add an additional ticket for it.

This feature is slated for a followup release and not for v1.0, so don't dedicate cycles here just yet.

@maxceem
Copy link
Contributor

maxceem commented Jan 19, 2021

@wdprice

Sum up:

  1. Implement Job View page as per new design https://marvelapp.com/prototype/921gg0f/screen/75360459/handoff

    • But also show "Start Date", "End Date", "Resource Type", "Rate Type", "Workload" and "Status"

    image

  2. Clicking "Eidt Job Details" should open edit job page https://marvelapp.com/prototype/921gg0f/screen/75360460/handoff

    image

  3. We should be also able to create a new job:

    image

Questions:

  1. What do these icons mean in the new design?:

    image

  2. To open Job View page, we should click Job Title, right?

    image

  3. All fields except memberRate

    Just to confirm, Job model at the moment doesn't have "memberRate" so we cannot show it and shouldn't hide it yet.

  4. As per design "Number of Openings" is Select, but I guess it should be text input which should only allow numbers 0 and more.

    image

  5. Should we also allow editing other fields "Start Date", "End Date", "Resource Type", "Rate Type", "Workload" and "Status"?

  6. Customer users per current permission can create Jobs and can edit jobs (but only jobs that they created). Should we allow the same in UI?

    image

@SathyaJayabal
Copy link
Collaborator

@maxceem @wdprice , these job updates must also be synced back to RCRM right?

@maxceem
Copy link
Contributor

maxceem commented Jan 23, 2021

@maxceem @wdprice , these job updates must also be synced back to RCRM right?

Nice catch @SathyaJayabal. @nkumar-topcoder what do you think about it?

@wdprice
Copy link
Author

wdprice commented Jan 26, 2021

  1. Also add duration. Calculate end date based on start date + duration (weeks)
  2. We will need to handle zapier flow for updates to existing jobs.
  3. Correct

Questions:

  1. Icons removed in latest designs
  2. Correct
  3. Correct, that only exists on resourceBooking
  4. TExt input is OK
  5. Edit Requested Start Date + Duration (add requested to the label). See 1. above.
  6. Yes, customer (or manager) role on Connect project can add a new job or edit.

@nkumar-topcoder
Copy link
Contributor

nkumar-topcoder commented Jan 27, 2021

@maxceem @wdprice , these job updates must also be synced back to RCRM right?

@maxceem @wdprice @SathyaJayabal
a) job updates to RCRM is already taken care in the initial sync.
b) So, adding/updating new job should take. However, once the UI implemented need to take care of any edge case scenario.
c) this is assumption that company and contact slug (id) at RCRM remain same as v1.0 release

@maxceem
Copy link
Contributor

maxceem commented Feb 8, 2021

This is ready for QA on DEV, except for a few things:

Not yet done:

  • duration is not added yet, as business required are not yet confirmed, so for now we have start/end date
  • Edit button, for now, is visible for all the users, we would hide it after we implement member access management Project Access Management Controls #14

@SathyaJayabal
Copy link
Collaborator

@maxceem , I do not see the edits made from the job edits page getting saved. There is no error on the PUT api call.

Screen.Recording.2021-02-08.at.5.48.34.PM.mov

@maxceem
Copy link
Contributor

maxceem commented Feb 8, 2021

Right, there should not be any error. sorry, misunderstood you, please ignore this.

@sandhiyakavi
Copy link
Collaborator

Adding to the above,

  1. Topcoder Member is not able to edit the job created along with the taas project in Connect (Taas project is created by the same Topcoder member) but has permission to edit the one created in the UI by the member.
    image
    image

  2. Able to add End date less than the Start date

image

  1. Able to set Status for Job as Closed/Cancelled while Creating the Job.

image

@maxceem
Copy link
Contributor

maxceem commented Feb 9, 2021

@SathyaJayabal editing jobs works now. Changes should be reflected after you save the Job. Please, let me know if you have such issues again.

@sandhiyakavi
Copy link
Collaborator

@maxceem Able to Edit jobs now but
1.Able to set status as 'Assigned' for a job even if no candidate is assigned to the job. User should not be allowed to change status 'Assigned' in this scenario right?

image

  1. The issues mentioned in comment Jobs Edit UI #12 (comment) is existing

@maxceem
Copy link
Contributor

maxceem commented Feb 9, 2021

Topcoder Member is not able to edit the job created along with the taas project in Connect (Taas project is created by the same Topcoder member) but has permission to edit the one created in the UI by the member.

Great catch, and valid issue. We would fix it in Projects API.

Able to add End date less than the Start date

Will add validation.

Questions to Business

Should we add any restrictions for these or we can keep these as it is.

  1. Able to set Status for Job as Closed/Cancelled while Creating the Job.

2.Able to set status as 'Assigned' for a job even if no candidate is assigned to the job. User should not be allowed to change status 'Assigned' in this scenario right?

@wdprice
Copy link
Author

wdprice commented Feb 9, 2021

Let's place the status field in read only only. Only BookingManager / Topcoder Admin can edit those fields.

@maxceem maxceem mentioned this issue Feb 13, 2021
5 tasks
@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

@sandhiyakavi some of the issues are fixed now. And for some of them I've created separate issue for easier control. So after testing the fixed part, could we mark this issue as QA passed, and we would handle not yet fixed issues separately.

  1. Topcoder Member is not able to edit the job created along with the taas project in Connect (Taas project is created by the same Topcoder member) but has permission to edit the one created in the UI by the member.

Already fixed. You may test it by creating a new Project. For the Project which is already created, it cannot be fixed.

  1. Able to add End date less than the Start date

This would be fixed by #84

  1. Able to set Status for Job as Closed/Cancelled while Creating the Job.
    4.Able to set status as 'Assigned' for a job even if no candidate is assigned to the job. User should not be allowed to change status 'Assigned' in this scenario right?

As per Will clarification, we would not fix these. But we would add restriction on who can change status. This would be done by #83

@sandhiyakavi
Copy link
Collaborator

Verified in Dev env .Comment #1 is working now

image

@sandhiyakavi
Copy link
Collaborator

Fixed: 🆗 in Production via milestone v1.5

  1. Able to create job
    image
  2. View Job details page.
    image

@lakshmiathreya Edit Job details button is visible only to BookingManager/Admin. Need to try Job editing using Booking Manager role.

@lakshmiathreya
Copy link

Screenshot 2021-02-26 at 2 04 16 PM

Screenshot 2021-02-26 at 2 06 26 PM

@lakshmiathreya
Copy link

lakshmia3006 is a bookingmanager in Prod ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants