Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$40] Jobs View/Edit UI: Replace "End Date" field by "Duration" field #84

Closed
maxceem opened this issue Feb 13, 2021 · 19 comments
Closed

Comments

@maxceem
Copy link
Contributor

maxceem commented Feb 13, 2021

For Jobs we've removed endDate for jobs and added duration instead in API topcoder-platform/taas-apis#143.

So now we have to update Job View Details page to show "Duration" instead of "End Date"

image

And same for Job Edit Detail page:

image

During editing, the "Duration" field should be:

  • input which only allows entering integer values 1 or more
  • it's optional, so we can remove the value
  • show it instead of "End Date"
@maxceem maxceem mentioned this issue Feb 13, 2021
@maxceem maxceem changed the title Jobs View/Edit UI: Replace "End Date" field by "Duration" field [$35] Jobs View/Edit UI: Replace "End Date" field by "Duration" field Feb 13, 2021
@maxceem maxceem added CF enhancement New feature or request labels Feb 13, 2021
@maxceem maxceem changed the title [$35] Jobs View/Edit UI: Replace "End Date" field by "Duration" field [$40] Jobs View/Edit UI: Replace "End Date" field by "Duration" field Feb 13, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/7cda4ef6-ec78-48b8-96c2-02a9691061ee has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@yoution ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@maxceem
Copy link
Contributor Author

maxceem commented Feb 13, 2021

Challenge https://www.topcoder.com/challenges/7cda4ef6-ec78-48b8-96c2-02a9691061ee has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

@yoution
Copy link
Contributor

yoution commented Feb 13, 2021

@bug-bash-helper #94 is ready for review

@bug-bash-hunt-helper
Copy link

@yoution ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@maxceem maxceem added Feedback The issue hasn't been fixed completely and some feedback has been provided. ACCEPTED tcx_FixAccepted Ready for DEV QA and removed Ready for Review Feedback The issue hasn't been fixed completely and some feedback has been provided. labels Feb 16, 2021
@sandhiyakavi
Copy link
Collaborator

Verified on Dev Env. Working as expected.

image
image

@nkumar-topcoder
Copy link
Contributor

nkumar-topcoder commented Feb 18, 2021

@sandhiyakavi - please check for below cases and update accordingly

a) try to edit for a job and duration is TBD initially change to 2 weeks. Saving is not happening.

https://platform.topcoder-dev.com/taas/myteams/17091/positions/b4ee7bd4-c658-46d7-a1e6-e46e94369a32/edit

b) Create a new position with duration as monthly. Save acknowledgement msg appears. Verify on the page you will see still it display for weeks
image
image

maxceem added a commit that referenced this issue Feb 18, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 18, 2021

a) try to edit for a job and duration is TBD initially change to 2 weeks. Saving is not happening. https://platform.topcoder-dev.com/taas/myteams/17091/positions/b4ee7bd4-c658-46d7-a1e6-e46e94369a32/edit

This is fixed by b0d6864. Could you please, try now?
The issue was because some jobs have skills ids which are not returned by V5. Now, I'm showing such skills as Unsupported value: "12123-12313-12e2-12e12-" so we would be aware if this happens and try to fix such data inconsistencies:

image

b) Create a new position with duration as monthly. Save acknowledgement msg appears. Verify on the page you will see still it display for weeks

@nkumar-topcoder the field for weeks/months is called Rate Type so it suppose to be for the rating, not for duration. As per my understanding, the duration should always be in weeks. Please, confirm if you would like to also apply it for Duration as your text above?

@nkumar-topcoder
Copy link
Contributor

nkumar-topcoder commented Feb 18, 2021

@maxceem Got it. Totally got confused.
cc @sandhiyakavi - pls ignore 2nd case.

@wdprice, max - to avoid confusion
a) can we add small label next to duration as default weekly
b) I think it's better to re-phrase rate type at least in frontend - something like Resource Rate Frequency

This could be common scenario and queries from end user that we can anticipate in future. Re-phrasing could help.

@nkumar-topcoder
Copy link
Contributor

@maxceem @sandhiyakavi verified for case a) able to save. Thanks

maxceem added a commit that referenced this issue Feb 18, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 18, 2021

@nkumar-topcoder I've updated the labels by

image

and during view:

image

@sandhiyakavi
Copy link
Collaborator

@maxceem The above changes for Duration and Rate type labels are not reflected for Create Job page.

image

Verified for all the duration cases. Working as expected.

maxceem added a commit that referenced this issue Feb 19, 2021
- made create job form same to edit

ref issue #84
@maxceem
Copy link
Contributor Author

maxceem commented Feb 19, 2021

@maxceem The above changes for Duration and Rate type labels are not reflected for Create Job page.

Fixed via d8604e6

Ready for QA on DEV.

@sandhiyakavi
Copy link
Collaborator

Verified .The labels are correctly getting displayed

image

@maxceem maxceem closed this as completed Feb 19, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 19, 2021

Payment failed: [400]: Failed to activate challenge. Detail: Cannot Activate this project, it has no active billing accounts.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 19, 2021
@maxceem maxceem closed this as completed Feb 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Feb 21, 2021

Payment task has been updated: https://www.topcoder.com/challenges/7cda4ef6-ec78-48b8-96c2-02a9691061ee
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge 7cda4ef6-ec78-48b8-96c2-02a9691061ee has been paid and closed.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem reopened this Feb 21, 2021
@codejamtc
Copy link
Collaborator

codejamtc commented Feb 25, 2021

Fixed: 🆗 in Production via milestone v1.5

URL: https://platform.topcoder.com/taas/myteams/26861/positions/8853c864-36bb-44ad-bcf6-1d2e871b799c

  • So now we have to update Job View Details page to show "Duration" instead of "End Date"

bandicam 2021-02-25 20-57-57-512

bandicam.2021-02-26.10-14-05-757.mp4

URL: https://platform.topcoder.com/taas/myteams/26859/positions/ab7fdfc5-2e62-40d6-b630-91a2cd498eb7
URL: https://platform.topcoder.com/taas/myteams/26859/positions/9cb3e613-09e9-4549-a657-d21136004015

bandicam.2021-02-25.21-20-38-193.mp4

@lakshmiathreya Please check the below using manager role, Thanks

During editing, the "Duration" field should be:

  • input which only allows entering integer values 1 or more
  • it's optional, so we can remove the value
  • show it instead of "End Date"

@lakshmiathreya
Copy link

This is seen with Manager role: @sandhiyakavi @codejamtc pls clarify - the Requirement seems to be to replace End date with Duration - which is seen as expected. Is it still QA Fail?
Screenshot 2021-02-26 at 2 57 52 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants