Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue-84 #94

Merged
merged 2 commits into from
Feb 17, 2021
Merged

fix: issue-84 #94

merged 2 commits into from
Feb 17, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Feb 13, 2021

No description provided.

@yoution yoution mentioned this pull request Feb 13, 2021
Closed
maxceem
maxceem suggested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution there is one thing regarding it.

This field should be optional, so we should be able to remove the value. But at the moment I cannot remove the value. I would always show 1 if I try to remove it.

image

@yoution yoution requested a review from maxceem February 17, 2021 04:10
maxceem
maxceem suggested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution can remove the value now. But also, now can enter 0 but if we enter some value the minimal value has to be 1.

maxceem
maxceem approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad @yoution. I've tested the wrong field. This PR works perfectly.

@maxceem maxceem merged commit ad02cdf into topcoder-archive:dev Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoution @maxceem