Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Modal component, payment cancelling, processing errors in popovers and other improvements #62

Merged
merged 12 commits into from
Jul 5, 2021

Conversation

MadOPcode
Copy link
Contributor

Implements #54 #56 #57 #61.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. On this page all the rows become higher and there is a horizontal scrollbar even though on other pages there is no scrollbar and rows has smaller height https://platform.topcoder-dev.com/taas-admin/work-periods?startDate=2021-06-27&by=user_handle&order=asc&perPage=10&page=1

    image

    Before applying this PR it looked good:

    image

  2. Sorry, I've missed this case. Let's hide the Cancel button when payment is canceled:

    image

@maxceem
Copy link
Contributor

maxceem commented Jul 5, 2021

@MadOPcode I pushed small fixes for #48 and it causes merge conflicts now. Could you, please, pull the latest changes from dev branch to resolve merge conflicts for this PR.

@MadOPcode MadOPcode requested a review from maxceem July 5, 2021 11:17
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadOPcode all works perfectly now.

@maxceem maxceem merged commit 878a2a7 into topcoder-archive:dev Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants