Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$50] Nice to have: userhandle near WP id for the Warning messages displayed during multiple payment process #54

Closed
sandhiyakavi opened this issue Jun 28, 2021 · 8 comments

Comments

@sandhiyakavi
Copy link
Collaborator

Description:

Currently for mentioning the error only WP id of the Resource is mentioned in the warning messages of multiple payment process. It would be nice to have Userhandle near the WP id for easy identifying of the particular resource.

Steps to Reproduce:

  1. Make the member rate zero for a resouce.
  2. Remove the BA of another resource.
  3. Make daysworked as 0 for another resouce.
  4. Choose a payment completed resource.
  5. Process payment for above resources.

error_check

@maxceem
Copy link
Contributor

maxceem commented Jun 30, 2021

Sum up:

I suggested instead of adding user handles to the error messages, move the errors messages to the rows.

  • When error of payment processing happens to some row, we already make such rows red color now.

  • Additionally to that, add a red circle with ! inside on the right to the checkbox like this:

    image

    • when we click on it, show a popover with error message from the server. Similar to how we show error here, but only server error message without any other info:

      image

  • Remove the list of error messages from the toastr. Only show how many payment were successfully scheduled and how many failed, but without the list of error messages.

@maxceem maxceem added the CF Issues for Community Fixes label Jun 30, 2021
@maxceem maxceem changed the title Nice to have: userhandle near WP id for the Warning messages displayed during multiple payment process [$50] Nice to have: userhandle near WP id for the Warning messages displayed during multiple payment process Jun 30, 2021
@sandhiyakavi
Copy link
Collaborator Author

@maxceem Currently only for select all records, Failed to schedule payment is displayed but for that too, 'red circle with ! on the right to the checkbox' is not shown

failed

bandicam.2021-07-06.14-57-27-611.mp4

@maxceem
Copy link
Contributor

maxceem commented Jul 6, 2021

@sandhiyakavi Got your point. This feature to pay ALL the payments were implemented to support a big number of payments. So we implemented API to NOT return actually errors that happened, only the number of success and failed payments. This was done this way for a case if there many errors, then server response might be heavy. That's why at the moment we cannot show details of errors.

Though we can give it a try and implement it. I suggest logging a separate issue for this case where we could discuss the details, as there are some questions raise up.

@sandhiyakavi
Copy link
Collaborator Author

@maxceem I think there is no way to test this with either single or multiple payments after the implementation of this #48 right?

@maxceem
Copy link
Contributor

maxceem commented Jul 6, 2021

Ah, yes, @sandhiyakavi when I tested it locally, I disabled #48 so I can see the error details messages.

@sandhiyakavi
Copy link
Collaborator Author

@maxceem I marked this as pass, as this issue will be resolved with #48

@maxceem
Copy link
Contributor

maxceem commented Jul 7, 2021

@maxceem maxceem added the PAID label Jul 7, 2021
@sandhiyakavi
Copy link
Collaborator Author

Verified on Prod Env with @nkumar-topcoder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants