Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Show error details when all payments are failed #55

Closed
maxceem opened this issue Jul 1, 2021 · 5 comments
Closed

Show error details when all payments are failed #55

maxceem opened this issue Jul 1, 2021 · 5 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Jul 1, 2021

At the moment when some payments are failed and some are successful we are showing error details for failed payments:

image

But if all payments are failed we are not showing error details:

image

We should show error details in both cases. So we always would like to know the error details of the failed payments.

@maxceem maxceem added P4 CF Issues for Community Fixes labels Jul 1, 2021
@maxceem maxceem changed the title Show error details when all payments are failed [$10] Show error details when all payments are failed Jul 1, 2021
@MadOPcode
Copy link
Contributor

@maxceem to clarify, should the error details be shown as described in #54?

@maxceem
Copy link
Contributor Author

maxceem commented Jul 3, 2021

@MadOPcode no. I mean in the toastr. See screenshots above:

  • when some of the payments is success - we show error details
    -but when all payments are failed, we don't show error details

So we have to show error details inside toastr even if all payments are failed like this in toastr:

image

@MadOPcode
Copy link
Contributor

@maxceem but in #54 you wrote:

Remove the list of error messages from the toastr. Only show how many payment were successfully scheduled and how many failed, but without the list of error messages.

So should the error messages be both in the popovers near checkboxes and in the toastrs or only in the popovers?

@maxceem
Copy link
Contributor Author

maxceem commented Jul 3, 2021

Ah, you are right. So the current issue is not needed anymore. As we would not show error messages in toaster anymore. We would always show them near checkboxes.

Please, ignore this issue.

@maxceem maxceem removed the CF Issues for Community Fixes label Jul 3, 2021
@maxceem maxceem changed the title [$10] Show error details when all payments are failed Show error details when all payments are failed Jul 3, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Jul 5, 2021

This is no longer needed, as per #54 we are showing errors inside the rows instead of toastrt.

@maxceem maxceem closed this as completed Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants