Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$30] Nice to have: Failure message with the reason for failure. #48

Closed
sandhiyakavi opened this issue Jun 24, 2021 · 8 comments
Closed

Comments

@sandhiyakavi
Copy link
Collaborator

Description:

Currently if there was a failure in scheduling the payment, we are getting the error message "Failed to schedule payments for (n) resources" for all below reason,

  1. If member Rate is 0 or null
  2. If the RB.billingaccount is null.
  3. If status='no days'

It will be nice if there is a reason added for the failure as it would be easier to find the reason

image

@maxceem
Copy link
Contributor

maxceem commented Jun 30, 2021

Sum up:

  • I suggest another approach, instead of showing error after attempt of processing the payment we should disable the checkboxes if we cannot process the payment for a known reason.
    • disable checkboxes for the rows for which we cannot process a payment because of one of the reasons shown below
    • when we put mouse on a disabled checkbox show the Tooltip with the message describing the reason why we cannot process the payment for this row
    • if we click checkbox to select all it should not select disabled checkboxes.

Possible Reasons:

  • RB.mamberRate is 0 or null, message: Member Rate should be more than 0.
  • RB.billingAccount is null, message: Billing Account is not set for the Resorce Booking.
  • if RB.workPeriods[0].daysWorked - RB.workPeriods[0].daysPaid === 0, message: There are no days to pay.

Blocked:

@maxceem maxceem added CF Issues for Community Fixes Blocked labels Jun 30, 2021
@maxceem maxceem changed the title Nice to have: Failure message with the reason for failure. [$30] Nice to have: Failure message with the reason for failure. Jun 30, 2021
@maxceem maxceem removed the CF Issues for Community Fixes label Jul 1, 2021
@maxceem
Copy link
Contributor

maxceem commented Jul 1, 2021

@MadOPcode please, hold with this issue, I would update the requirement here.

@maxceem maxceem added the CF Issues for Community Fixes label Jul 1, 2021
@maxceem
Copy link
Contributor

maxceem commented Jul 1, 2021

@MadOPcode all good now, nothing has been changed.

@sandhiyakavi
Copy link
Collaborator Author

@maxceem 1. The 'Resource' spelling is incorrect in the tooltip.

image

  1. Also can we have a bulletin point or similar one to display these messages if they are more than one?

image

Other than the above two, it is working fine

@maxceem
Copy link
Contributor

maxceem commented Jul 5, 2021

@sandhiyakavi both are fixed now and pushed to DEV.

@sandhiyakavi
Copy link
Collaborator Author

Verified on Dev Env.

image

@maxceem
Copy link
Contributor

maxceem commented Jul 7, 2021

@maxceem maxceem added the PAID label Jul 7, 2021
@sandhiyakavi
Copy link
Collaborator Author

Verified on Prod Env with @nkumar-topcoder

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants