-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(CONTRIBUTING): update links #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(CONTRIBUTING): update links #932
Conversation
... the old egghead.io link redirects to https://app.egghead.io/playlists/how-to-contribute-to-an-open-source-project-on-github which displays "We've got a new version of egghead in BETA. Click here to try it!" remove obsolete all-contributors link (was removed in 29aad25)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 97b5a99:
|
I agree with using the spelling TypeScript which is consistent with Microsoft's spelling, but why is the Egghead link changed? It seems like both links work but use different themes. Do they have a new backend? |
Hi @nickmccurdy Thanks for reviewing my PR. For example the link on top: So the page used to be in Beta some time ago, but is now the new official egghead.io Look&Feel. |
Codecov Report
@@ Coverage Diff @@
## main #932 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 140 140
Branches 26 26
=========================================
Hits 140 140 Continue to review full report at Codecov.
|
@all-contributors add @leschdom for docs |
@nickmccurdy I've put up a pull request to add @leschdom! 🎉 |
* docs(CONTRIBUTING): update links ... the old egghead.io link redirects to https://app.egghead.io/playlists/how-to-contribute-to-an-open-source-project-on-github which displays "We've got a new version of egghead in BETA. Click here to try it!" remove obsolete all-contributors link (was removed in 29aad25) * docs: use consistent spelling for TypeScript ... inspired by https://effectivetypescript.com/2021/02/03/pet-peeves/ Co-authored-by: Matan Borenkraout <[email protected]>
🎉 This PR is included in version 12.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Update links (e.g. egghead.io link redirects to some old preview page for their newly launched site).
Renamed
Typescript
toTypeScript
(As I did with my first PR on the cypress-testing-library (testing-library/cypress-testing-library#180))
Why:
It could be confusing for first-time contributors (egghead.io links)
It gives a even more professional look when the naming of tools etc. is spelled correctly (at least to me 😅)
How:
Searched for the correct links:
OLD: https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
NEW: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github
Have found a source to link why I would like to update the TypeScript spelling:
https://effectivetypescript.com/2021/02/03/pet-peeves/
Checklist:
docs site N/A