Skip to content

Commit 801edaa

Browse files
leschdomMatanBobi
andauthored
docs(CONTRIBUTING): update links (#932)
* docs(CONTRIBUTING): update links ... the old egghead.io link redirects to https://app.egghead.io/playlists/how-to-contribute-to-an-open-source-project-on-github which displays "We've got a new version of egghead in BETA. Click here to try it!" remove obsolete all-contributors link (was removed in 29aad25) * docs: use consistent spelling for TypeScript ... inspired by https://effectivetypescript.com/2021/02/03/pet-peeves/ Co-authored-by: Matan Borenkraout <[email protected]>
1 parent 6e6bf85 commit 801edaa

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ merge of your pull request!
3737
- [ ] Documentation added to the
3838
[docs site](https://github.com/testing-library/testing-library-docs)
3939
- [ ] Tests
40-
- [ ] Typescript definitions updated
40+
- [ ] TypeScript definitions updated
4141
- [ ] Ready to be merged
4242
<!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
4343

CONTRIBUTING.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ sure to include those changes (if they exist) in your commit.
3535
### Update Typings
3636
3737
If your PR introduced some changes in the API, you are more than welcome to
38-
modify the Typescript type definition to reflect those changes. Just modify the
39-
`/types/index.d.ts` file accordingly. If you have never seen Typescript
38+
modify the TypeScript type definition to reflect those changes. Just modify the
39+
`/types/index.d.ts` file accordingly. If you have never seen TypeScript
4040
definitions before, you can read more about it in its
4141
[documentation pages](https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html).
42-
Though this library itself is not written in Typescript we use
42+
Though this library itself is not written in TypeScript we use
4343
[dtslint](https://github.com/microsoft/dtslint) to lint our typings.
4444
4545
## Help needed
@@ -50,6 +50,5 @@ Also, please watch the repo and respond to questions/bug reports/feature
5050
requests! Thanks!
5151
5252
[egghead]:
53-
https://app.egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
54-
[all-contributors]: https://github.com/all-contributors/all-contributors
53+
https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github
5554
[issues]: https://github.com/testing-library/react-testing-library/issues

0 commit comments

Comments
 (0)