Skip to content

docs(CONTRIBUTING): update links #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leschdom
Copy link
Contributor

@leschdom leschdom commented Jun 13, 2021

What:
Update links (e.g. egghead.io link redirects to some old preview page for their newly launched site).
Renamed Typescript to TypeScript
(As I did with my first PRs on the cypress-testing-library and react-testing-library)

Why:
It could be confusing for first-time contributors (egghead.io links)
It gives a even more professional look when the naming of tools etc. is spelled correctly (at least to me 😅)

How:
Searched for the correct links:
OLD: https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
NEW: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github

Have found a source to link why I would like to update the TypeScript spelling:
https://effectivetypescript.com/2021/02/03/pet-peeves/

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a88c2d:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #977 (2a88c2d) into main (75197fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #977   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          914       914           
  Branches       283       283           
=========================================
  Hits           914       914           
Flag Coverage Δ
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75197fe...2a88c2d. Read the comment docs.

@nickserv nickserv merged commit d941cbd into testing-library:main Jul 12, 2021
@leschdom leschdom deleted the feature/update-contributing-documentation branch July 13, 2021 07:56
@nickserv
Copy link
Member

@all-contributors add @leschdom for docs

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @leschdom! 🎉

@github-actions
Copy link

🎉 This PR is included in version 8.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants