Skip to content

docs(CONTRIBUTING): update links #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leschdom
Copy link
Contributor

What:
Update links (e.g. egghead.io link redirects to some old preview page for their newly launched site).

Why:
It could be confusing for first-time contributors (like me) 😄

How:
Searched for the correct links:
OLD: https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
NEW: https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github

Replaced old references to kentcdodds repo with the new one testing-library (even though the redirects seem to work fine)

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged

It might also be something to check the other repositories if they have the same outdated links. 🤔

Copy link
Contributor

@NicholasBoll NicholasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@NicholasBoll NicholasBoll merged commit 1f65c84 into testing-library:main Jun 2, 2021
@NicholasBoll
Copy link
Contributor

@all-contributors please add @leschdom for doc :)

@allcontributors
Copy link
Contributor

@NicholasBoll

I've put up a pull request to add @leschdom! 🎉

@github-actions
Copy link

🎉 This PR is included in version 7.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants