Skip to content

readme: add self-hosted runners and container jobs #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Totktonada
Copy link
Member

Running the action on a self-hosted runner or in a container job is supported since PR #45, but it requires a few additional steps. Let's describe them in the README.md file.

This PR also simplifies the container job in CI. See the first commit of the patchset for details.

Fixes #47

@Totktonada Totktonada requested a review from grafin February 26, 2024 23:06
The list of the changes is the following.

* Transformed `--no-install-recommends` and `--no-install-suggests` into
  `apt-get` configuration options to bring them into `apt-get` commands
  run by the `setup-tarantool` action. It reduces a list of installed
  dependencies and, so, reduces a size of the cache file (~200MB to
  ~30MB).
* Eliminated `apt-get upgrade`, because I see no reason to perform it.
  Kept `apt-get update` (refreshing of repositories metadata).
* Extracted the `tzdata` package installation to make the reason of this
  step clear.
* Clarified the `setup-node` invocation to make it clear that it is not
  a required step for using the setup-tarantool action is a container
  job.
* Updated setup-node action to v4, updated nodejs version to 20.

Part of #47
Running the action on a self-hosted runner or in a container job is
supported since PR #45, but it requires a few additional steps. Let's
describe them in the README.md file.

Fixes #47
@Totktonada Totktonada force-pushed the Totktonada/gh-47-document-self-hosted-runners-and-container-jobs branch from 59eef17 to 1ec5cc3 Compare February 27, 2024 00:15
Copy link
Member

@grafin grafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it! Only one nit from me, otherwise LGTM

@Totktonada Totktonada merged commit 1bbf995 into master Feb 27, 2024
@Totktonada Totktonada deleted the Totktonada/gh-47-document-self-hosted-runners-and-container-jobs branch February 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme needs an update
2 participants