Skip to content

Readme needs an update #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grafin opened this issue Feb 25, 2024 · 0 comments · Fixed by #49
Closed

Readme needs an update #47

grafin opened this issue Feb 25, 2024 · 0 comments · Fixed by #49
Labels
documentation Improvements or additions to documentation

Comments

@grafin
Copy link
Member

grafin commented Feb 25, 2024

Currently it states:

  • Runs on GitHub-hosted ubuntu-* runners only.

Which is not true anymore, it should run on any debian-based distro on runners and in containers. But it is tested only for ubuntu-* runners and several ubuntu:* and debian:* containers. See .github/workflows/test.yml and .github/workflows/test-docker.yml for details.

@grafin grafin added the documentation Improvements or additions to documentation label Feb 25, 2024
Totktonada added a commit that referenced this issue Feb 26, 2024
The list of the changes is the following.

* Transformed `--no-install-recommends` and `--no-install-suggests` into
  `apt-get` configuration options to bring them into `apt-get` commands
  run by the `setup-tarantool` action. It reduces a list of installed
  dependencies and, so, reduces a size of the cache file (~200MB to
  ~30MB).
* Eliminated `apt-get upgrade`, because I see no reason to perform it.
  Kept `apt-get update` (refreshing of repositories metadata).
* Eliminated the `tzdata` package installation, because, it seems, it is not used
  anywhere later (and will be pulled as a dependency if actually
  needed).
* Eliminated the `setup-node` invocation, because GitHub Actions runner
  adds a nodejs executable into the container using a docker volume.

Part of #47
Totktonada added a commit that referenced this issue Feb 26, 2024
Running the action on a self-hosted runner or in a container job is
supported since PR #45, but it requires a few additional steps. Let's
describe them in the README.md file.

Fixes #47
Totktonada added a commit that referenced this issue Feb 26, 2024
Running the action on a self-hosted runner or in a container job is
supported since PR #45, but it requires a few additional steps. Let's
describe them in the README.md file.

Fixes #47
Totktonada added a commit that referenced this issue Feb 26, 2024
The list of the changes is the following.

* Transformed `--no-install-recommends` and `--no-install-suggests` into
  `apt-get` configuration options to bring them into `apt-get` commands
  run by the `setup-tarantool` action. It reduces a list of installed
  dependencies and, so, reduces a size of the cache file (~200MB to
  ~30MB).
* Eliminated `apt-get upgrade`, because I see no reason to perform it.
  Kept `apt-get update` (refreshing of repositories metadata).
* Eliminated the `tzdata` package installation, because, it seems, it is not used
  anywhere later (and will be pulled as a dependency if actually
  needed).
* Clarified the `setup-node` invocation to make it clear that it is not
  a required step for using the setup-tarantool action is a container
  job.
* Updated setup-node action to v4, updated nodejs version to 20.

Part of #47
Totktonada added a commit that referenced this issue Feb 26, 2024
Running the action on a self-hosted runner or in a container job is
supported since PR #45, but it requires a few additional steps. Let's
describe them in the README.md file.

Fixes #47
Totktonada added a commit that referenced this issue Feb 27, 2024
The list of the changes is the following.

* Transformed `--no-install-recommends` and `--no-install-suggests` into
  `apt-get` configuration options to bring them into `apt-get` commands
  run by the `setup-tarantool` action. It reduces a list of installed
  dependencies and, so, reduces a size of the cache file (~200MB to
  ~30MB).
* Eliminated `apt-get upgrade`, because I see no reason to perform it.
  Kept `apt-get update` (refreshing of repositories metadata).
* Extracted the `tzdata` package installation to make the reason of this
  step clear.
* Clarified the `setup-node` invocation to make it clear that it is not
  a required step for using the setup-tarantool action is a container
  job.
* Updated setup-node action to v4, updated nodejs version to 20.

Part of #47
Totktonada added a commit that referenced this issue Feb 27, 2024
Running the action on a self-hosted runner or in a container job is
supported since PR #45, but it requires a few additional steps. Let's
describe them in the README.md file.

Fixes #47
Totktonada added a commit that referenced this issue Feb 27, 2024
The list of the changes is the following.

* Transformed `--no-install-recommends` and `--no-install-suggests` into
  `apt-get` configuration options to bring them into `apt-get` commands
  run by the `setup-tarantool` action. It reduces a list of installed
  dependencies and, so, reduces a size of the cache file (~200MB to
  ~30MB).
* Eliminated `apt-get upgrade`, because I see no reason to perform it.
  Kept `apt-get update` (refreshing of repositories metadata).
* Extracted the `tzdata` package installation to make the reason of this
  step clear.
* Clarified the `setup-node` invocation to make it clear that it is not
  a required step for using the setup-tarantool action is a container
  job.
* Updated setup-node action to v4, updated nodejs version to 20.

Part of #47
Totktonada added a commit that referenced this issue Feb 27, 2024
Running the action on a self-hosted runner or in a container job is
supported since PR #45, but it requires a few additional steps. Let's
describe them in the README.md file.

Fixes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant