Fix action not working on debians and in containers #45

grafin · 2024-02-22T14:04:03Z

There are two problems preventing this action working on debian (not ubuntu) and in containers. This PR fixes them, as well as some issues in our CI, preventing the tests to pass. See commit messages for more info.

Closes #44

src/main.ts

.github/workflows/test-docker.yml

.github/workflows/test.yml

Totktonada · 2024-02-24T21:37:20Z

Thank you for the decent work!

I would like to comment a situation with 'disappearing' of the tarantool-1.10.12 package (described by this commit from the PR). CI jobs that experience the problem use runs-on: ubuntu-latest. At the time of writing it meant Ubuntu Focal (20.04), but now it is Ubuntu Jammy (22.04). Tarantool 1.10 release series supports Ubuntu Jammy since the 1.10.14 release. There is no 1.10.12 package for Ubuntu Jammy.

I think we can build such package and deploy it to download.tarantool.org for convenience, but nothing actually stops us from using 1.10.14 in CI. I agree with your fix.

Totktonada

The patchset looks nice. I've nothing to add here except a few nits (see above).

Let's resolve them (or let me know that you're out of free time) and I'll proceed with the pull request.

.github/workflows/test-docker.yml

This should make this action usable on any debian-based distros.

In ubuntu:22.04 docker man dpkg contains following: "-L|--listfiles <package>... List files 'owned' by package(s)." `dpkg -L cmake` mentions file /usr/share/doc/cmake/NEWS.Debian.gz, which is not present in the system after successful `apt-get -y install cmake`. This file is not installed because it matches exclude-path in dpkg config, and `apt-get install` respects this config option, while `dpkg -L` doesn't. This leads to setup-tarantool failing during packaging cache. This patch filters `dpkg -L` output according to dpkg configs. Closes #44

In manpages-dev package there is a know bug with broken symlinks in /usr/share/man/man3/. There is no hope that it will be fixed. Let's add a hack to bypass it. More info: https://groups.google.com/g/linux.debian.bugs.dist/c/w5HiAxl7e7Y

Previously it was trying to install 1.10.12, which looks like it is not in our repository right now.

It has been deprecated sometime ago: actions/runner-images#6002

grafin · 2024-02-25T13:34:24Z

Thanks for in-depth review and help with figuring out some details! I've fixed everything you mentioned in your review, feel free merge if you have no further comments. I would also suggest rewriting .github/workflows/test.yml to use latest-version and verify-version now that they are fixed, but this is out of the scope of current PR.

Totktonada

Looks good for me. Thanks!

Running the action on a self-hosted runner or in a container job is supported since PR #45, but it requires a few additional steps. Let's describe them in the README.md file. Fixes #47

grafin force-pushed the grafin/distro-and-docker-fixes branch 13 times, most recently from c2d3ea2 to dbb5503 Compare February 22, 2024 16:14

grafin mentioned this pull request Feb 22, 2024

Fix ubuntu 22 #41

Closed

grafin force-pushed the grafin/distro-and-docker-fixes branch 3 times, most recently from a5d6d13 to 7069e81 Compare February 24, 2024 07:08

grafin requested a review from Totktonada February 24, 2024 07:11