Update package and ci to node20 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafin
force-pushed
the
update-node20
branch
2 times, most recently
from
58942ff to
e32ecfb
Compare
grafin
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
@yngvar-antonsson thanks for the patches! I've rebased it on fresh master and updated first commit message.
@Totktonada Can you make a new release after merging this, so I and @sergepetrenko can update our workflows to use this action instead of my fork.
grafin
force-pushed
the
update-node20
branch
from
e32ecfb to
50f2738
Compare
|
@grafin Shouldn't we rebuild the JS code after the node version change? I would like to add a check that a proper version of tarantool is installed (see details in #36 (comment)) before a release. This pitfall was already catched too many times by different users. I hope I can play with it tonight. Anyway, I'm going to release the action early this week. |
grafin
force-pushed
the
update-node20
branch
from
50f2738 to
e1799fa
Compare
Totktonada
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #42