Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Single-point graphql constructor #59

Closed
Totktonada opened this issue Feb 28, 2018 · 4 comments
Closed

Single-point graphql constructor #59

Totktonada opened this issue Feb 28, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request prio3 usability

Comments

@Totktonada
Copy link
Member

We should allow to omit explicit data accessor creation and provide graphql constructor receives all needed metainfo and data accessor name. It may look like that:

local gql_wrapper = graphql.new('space', {
    schemas = schemas,
    collections = collections,
    service_fields = service_fields,
    indexes = indexes,
}, {
   ...funcs if needed...
})

Reason: most of users just want to use one of on-board data accessors.

@Totktonada Totktonada added enhancement New feature or request prio3 labels Feb 28, 2018
Khatskevich added a commit that referenced this issue Mar 2, 2018
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`

Closes #25
Khatskevich added a commit that referenced this issue Mar 2, 2018
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`; see #63

Closes #25
Khatskevich added a commit that referenced this issue Mar 5, 2018
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`; see #63

Closes #25
Khatskevich added a commit that referenced this issue Mar 7, 2018
key points:
 - use clock.monotonic64() because it is fast and it changes without
   yields
 - add option `timeout_ms` to accessor.new()
 - after #59 the option should be moved to `tgql.compile()`; see #63

Closes #25
@SudoBobo SudoBobo self-assigned this Mar 16, 2018
@SudoBobo
Copy link
Contributor

What is the purpose of funcs here?

local gql_wrapper = graphql.new('space', {
    schemas = schemas,
    collections = collections,
    service_fields = service_fields,
    indexes = indexes,
}, {
   ...funcs if needed...
})

To overwrite 'space' or 'shard' functions like unflatten_tuple or get_index?

@Totktonada
Copy link
Member Author

@SudoBobo yep.

@Totktonada
Copy link
Member Author

@SudoBobo Can you please check whether this issue can be closed?

Totktonada added a commit that referenced this issue Apr 18, 2018
It is related to #59. Follow up is needed: #63.
@SudoBobo
Copy link
Contributor

Closed with #95

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request prio3 usability
Projects
None yet
Development

No branches or pull requests

2 participants